Draft
Conversation
By moving the whitespace from between the handlebars to inside them, six newlines are eliminated from each instantiation of Template.dynamic.. This is important for cases where you need to have no whitespace between the dynamic template content and the surrounding tags.
Remove fibers from codebase
[spacebars-compiler] Update uglify-js to 3.16.1
Eliminate whitespace in Template.dynamic
Deprecate UI package
…-es6 Move package templating compiler es6
Move package caching-html-compiler to ES6
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…e/decode-uri-component-0.2.2 Bump decode-uri-component from 0.2.0 to 0.2.2 in /site
Fix GitHub spelling
…elpers Feature: addd explicit helper name + viewname to errors, causes…
⬆️ (deps): update test-app dependencies and devDependencies to latest ✅ (test-app): remove ci.sh and update test:ci script for new workflow 📝 (test-app): update puppeteerRunner.js console logging for better debugging 🔧 (test-app): add .env to .gitignore to prevent leaking sensitive config
🔧 (ci): migrate from CircleCI to GitHub Actions, remove CircleCI config
znewsham
commented
Sep 26, 2025
| @@ -1,9 +1,12 @@ | |||
| /* global TemplatingTools CachingCompiler */ | |||
| // eslint-disable-next-line import/no-unresolved | |||
znewsham
commented
Sep 26, 2025
| @@ -1,9 +1,10 @@ | |||
| /* global CachingHtmlCompiler TemplatingTools */ | |||
znewsham
commented
Sep 26, 2025
| @@ -8,7 +8,7 @@ export function generateTemplateJS(name, renderFuncCode, useHMR) { | |||
| return ` | |||
znewsham
commented
Sep 26, 2025
| @@ -1,6 +1,7 @@ | |||
| import has from 'lodash.has'; | |||
| import { OrderedDict } from 'meteor/ordered-dict'; | |||
znewsham
commented
Sep 26, 2025
| if (HTML.isArray(cond) && cond.length === 0) | ||
| cond = false; | ||
| return !! cond; | ||
| if (HTML.isArray(cond) && cond.length === 0) return false; |
Author
There was a problem hiding this comment.
this appears to be mostly cleanup - but hard to validate. Will need to understand if these are backwards compatible if they're meaningful
znewsham
commented
Sep 26, 2025
| DOMBackend._$jq = $jq; | ||
|
|
||
|
|
||
| DOMBackend.getContext = function() { |
znewsham
commented
Sep 26, 2025
|
|
||
| // A constant empty array (frozen if the JS engine supports it). | ||
| var _emptyArray = Object.freeze ? Object.freeze([]) : []; | ||
| const _emptyArray = Object.freeze ? Object.freeze([]) : []; |
znewsham
commented
Sep 26, 2025
| import has from 'lodash.has'; | ||
|
|
||
| var EventSupport = Blaze._EventSupport = {}; | ||
| const EventSupport = Blaze._EventSupport = {}; |
znewsham
commented
Sep 26, 2025
|
|
||
| // It's meant to be used in `Promise` chains to report the error while not | ||
| // "swallowing" it (i.e., the chain will still reject). | ||
| Blaze._reportExceptionAndThrow = function (error) { |
znewsham
commented
Sep 26, 2025
| }; | ||
| } | ||
|
|
||
| Blaze._globalHelpers = { |
Author
There was a problem hiding this comment.
super relevant - backwards compatible
znewsham
commented
Sep 26, 2025
| }; | ||
|
|
||
| var wrapHelper = function (f, templateFunc) { | ||
| const wrapHelper = function (f, templateFunc, name = 'template helper') { |
znewsham
commented
Sep 26, 2025
| } | ||
|
|
||
| Blaze._lexicalBindingLookup = function (view, name) { | ||
| const binding = _lexicalBindingLookup(view, name); |
Author
There was a problem hiding this comment.
potentially meaningful - but looks to be backwards compatible
znewsham
commented
Sep 26, 2025
| if (_functionWrapped) | ||
| return function () { return theWith.dataVar.get(); }; | ||
| return theWith.dataVar.get(); | ||
| return function () { return theWith.dataVar.get()?.value; }; |
znewsham
commented
Sep 26, 2025
| } else { | ||
| if (htmljs instanceof Blaze.Template) { | ||
| // Try to construct a `Blaze.View` out of the object. If it works... | ||
| if (isPromiseLike(htmljs)) { |
znewsham
commented
Sep 26, 2025
| const attrUpdater = new ElementAttributesUpdater(elem); | ||
| const updateAttributes = function () { | ||
| const expandedAttrs = Blaze._expandAttributes(rawAttrs, parentView); | ||
| then(waitForAllAttributes(expandedAttrs), awaitedAttrs => { |
Author
There was a problem hiding this comment.
no idea if this is backwards compatible or not
znewsham
commented
Sep 26, 2025
| // version which escapes ` (backtick) as well. Underscore 1.5.2 does not. | ||
| Blaze._escape = (function() { | ||
| var escape_map = { | ||
| const escape_map = { |
znewsham
commented
Sep 26, 2025
|
|
||
| return Template._withTemplateInstanceFunc(tmplInstanceFunc, function () { | ||
| return v.apply(data, args); | ||
| const view = this; // passed by EventAugmenter |
znewsham
commented
Sep 26, 2025
| /// of name "with". Names are also useful when debugging, so in | ||
| /// general it's good for functions that create Views to set the name. | ||
| /// Views associated with templates have names of the form "Template.foo". | ||
| import { HTML } from 'meteor/htmljs'; |
znewsham
commented
Oct 21, 2025
| @@ -1,20 +1,20 @@ | |||
| Package.describe({ | |||
Author
There was a problem hiding this comment.
znewsham
commented
Oct 21, 2025
| @@ -1,20 +1,20 @@ | |||
| Package.describe({ | |||
Author
There was a problem hiding this comment.
znewsham
commented
Oct 21, 2025
| @@ -1,7 +1,7 @@ | |||
| Package.describe({ | |||
Author
There was a problem hiding this comment.
znewsham
commented
Oct 21, 2025
| @@ -1,7 +1,7 @@ | |||
| Package.describe({ | |||
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.