Skip to content

Make compatible 3.0#3

Draft
znewsham wants to merge 246 commits intomake-compatible-2.6.2from
make-compatible-3.0
Draft

Make compatible 3.0#3
znewsham wants to merge 246 commits intomake-compatible-2.6.2from
make-compatible-3.0

Conversation

@znewsham
Copy link

No description provided.

znewsham and others added 30 commits May 8, 2021 14:04
By moving the whitespace from between the handlebars to inside them, six newlines are eliminated from each instantiation of Template.dynamic.. This is important for cases where you need to have no whitespace between the dynamic template content and the surrounding tags.
[spacebars-compiler] Update uglify-js to 3.16.1
Eliminate whitespace in Template.dynamic
…-es6

Move package templating compiler es6
Move package caching-html-compiler to ES6
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…e/decode-uri-component-0.2.2

Bump decode-uri-component from 0.2.0 to 0.2.2 in /site
StorytellerCZ and others added 8 commits November 1, 2024 04:03
…elpers

Feature: addd explicit helper name + viewname to errors, causes…
⬆️ (deps): update test-app dependencies and devDependencies to latest
✅ (test-app): remove ci.sh and update test:ci script for new workflow
📝 (test-app): update puppeteerRunner.js console logging for better debugging
🔧 (test-app): add .env to .gitignore to prevent leaking sensitive config
🔧 (ci): migrate from CircleCI to GitHub Actions, remove CircleCI config
@@ -1,9 +1,12 @@
/* global TemplatingTools CachingCompiler */
// eslint-disable-next-line import/no-unresolved
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no meaningful changes

@@ -1,9 +1,10 @@
/* global CachingHtmlCompiler TemplatingTools */
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant

@@ -8,7 +8,7 @@ export function generateTemplateJS(name, renderFuncCode, useHMR) {
return `
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant

@@ -1,6 +1,7 @@
import has from 'lodash.has';
import { OrderedDict } from 'meteor/ordered-dict';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant

if (HTML.isArray(cond) && cond.length === 0)
cond = false;
return !! cond;
if (HTML.isArray(cond) && cond.length === 0) return false;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to be mostly cleanup - but hard to validate. Will need to understand if these are backwards compatible if they're meaningful

DOMBackend._$jq = $jq;


DOMBackend.getContext = function() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards compatible


// A constant empty array (frozen if the JS engine supports it).
var _emptyArray = Object.freeze ? Object.freeze([]) : [];
const _emptyArray = Object.freeze ? Object.freeze([]) : [];
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant

import has from 'lodash.has';

var EventSupport = Blaze._EventSupport = {};
const EventSupport = Blaze._EventSupport = {};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant


// It's meant to be used in `Promise` chains to report the error while not
// "swallowing" it (i.e., the chain will still reject).
Blaze._reportExceptionAndThrow = function (error) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards compatible

};
}

Blaze._globalHelpers = {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super relevant - backwards compatible

};

var wrapHelper = function (f, templateFunc) {
const wrapHelper = function (f, templateFunc, name = 'template helper') {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards compatible

}

Blaze._lexicalBindingLookup = function (view, name) {
const binding = _lexicalBindingLookup(view, name);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially meaningful - but looks to be backwards compatible

if (_functionWrapped)
return function () { return theWith.dataVar.get(); };
return theWith.dataVar.get();
return function () { return theWith.dataVar.get()?.value; };
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT backwards compatible

} else {
if (htmljs instanceof Blaze.Template) {
// Try to construct a `Blaze.View` out of the object. If it works...
if (isPromiseLike(htmljs)) {
Copy link
Author

@znewsham znewsham Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards compatible

const attrUpdater = new ElementAttributesUpdater(elem);
const updateAttributes = function () {
const expandedAttrs = Blaze._expandAttributes(rawAttrs, parentView);
then(waitForAllAttributes(expandedAttrs), awaitedAttrs => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea if this is backwards compatible or not

// version which escapes ` (backtick) as well. Underscore 1.5.2 does not.
Blaze._escape = (function() {
var escape_map = {
const escape_map = {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant


return Template._withTemplateInstanceFunc(tmplInstanceFunc, function () {
return v.apply(data, args);
const view = this; // passed by EventAugmenter
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant

/// of name "with". Names are also useful when debugging, so in
/// general it's good for functions that create Views to set the name.
/// Views associated with templates have names of the form "Template.foo".
import { HTML } from 'meteor/htmljs';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume all this is relevant

@@ -1,20 +1,20 @@
Package.describe({
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,20 +1,20 @@
Package.describe({
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,7 +1,7 @@
Package.describe({
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,7 +1,7 @@
Package.describe({
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.