Open
Conversation
znewsham
force-pushed
the
znewsham/fix-types
branch
from
a79818c to
a26caef
Compare
znewsham
force-pushed
the
znewsham/fix-types
branch
from
a26caef to
c2be5f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress - i'm nervous of making the change I'd need to make (converting d.ts files to use
@meteor/*imports)meteor.d.ts imports blaze, mongo, ejson and ddp :| each of which imports meteor, causing a nice little circular dependency, but also - it's defining things on it's namespace that don't actually exist on the namespace - only when you've imported each of those (mongo => accounts-base) do those things actually become available.