Refine help messages and improve loop control #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
テストケースの |
shun0923
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このコミットの精緻化にあたる内容です。
18839ad
作業していて気付いた点として、そもそも_find_factor関数はテストの範囲内だと呼ばれてすらいないので、このオプションに対するテストとして不十分です。新しくLoopControllerで指定しているループ回数が、元々の秒数指定に対して本当に等価な振る舞いをしているか確かめるうえでも、テストを追加した方が良いかもしれません。
このPRは全く急ぎの内容ではないので、お時間があるときにゆっくりご確認いただくのがいいと思います。