Convert epsilon to mpf on constructing EpsilonRegion #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow the caller of the functions gridsynth and gridsynth_gates to pass epsilon of type `float`, rather than requiring an mpf. One expects that epsilon may be a `float`. This will help avoid bugs due to this expectation.
Contributor
|
Hi @jlapeyre, thank you very much for pointing this out. You're absolutely right that we should allow |
Contributor
Author
|
I think that is correct. I agree, it's a great idea to adjust the hyperparameters automatically as well. Presumably, the adequate dps depends on epsilon, but not on the angle. |
Contributor
|
This will be taken care of in different thread such as #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the caller of the functions gridsynth and gridsynth_gates to pass epsilon of type
float, rather than requiring an mpf.One expects that epsilon may be a
float. This will help avoid bugs due to this expectation.