Skip to content

Conversation

@cwickham
Copy link
Collaborator

@cwickham cwickham commented Oct 7, 2025

Description

Add page-numbering to the schema for format: typst

Required for #13515

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Oct 7, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@cwickham cwickham marked this pull request as ready for review October 7, 2025 20:48
@cderv
Copy link
Collaborator

cderv commented Oct 8, 2025

Was this added in v1.8?

It would mean we need to backport the schema change to v1.8 too so that it works in auto-completion and YAML validation

@cwickham
Copy link
Collaborator Author

cwickham commented Oct 8, 2025

I think 1.7 😬

@cderv
Copy link
Collaborator

cderv commented Oct 8, 2025

backporting to 1.8 seems needed then. Too late for 1.7 😓

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the page-numbering option to the schema for Typst format documents. This option allows users to control page numbering style (e.g., 1 for Arabic numerals, i for Roman numerals) or disable it entirely with false.

  • Adds new page-numbering schema option accepting either a boolean or string value
  • Restricts the option to Typst format only via format tags
  • Includes documentation with reference to Typst's numbering documentation

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
src/resources/schema/document-numbering.yml Defines the new page-numbering option schema with boolean/string types, Typst format tag, and descriptive documentation
src/resources/editor/tools/yaml/yaml-intelligence-resources.json Generated JSON resource file reflecting the new schema definition for YAML intelligence
src/resources/editor/tools/yaml/web-worker.js Generated web worker JavaScript including the new schema for editor tooling
src/resources/editor/tools/vs-code.mjs Generated VS Code extension module with the new schema definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cderv and others added 3 commits January 8, 2026 11:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts:
#	src/resources/editor/tools/vs-code.mjs
#	src/resources/editor/tools/yaml/all-schema-definitions.json
#	src/resources/editor/tools/yaml/web-worker.js
#	src/resources/editor/tools/yaml/yaml-intelligence-resources.json
@cderv
Copy link
Collaborator

cderv commented Jan 8, 2026

Sorry, I forgot to merge this. I fixed the conflict and the typo. I'll open the backport too

cderv pushed a commit that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants