Derive PartiaEq & Eq and fix chrono deprecated warning#4
Open
elpiel wants to merge 2 commits intoquebin31:masterfrom
Open
Derive PartiaEq & Eq and fix chrono deprecated warning#4elpiel wants to merge 2 commits intoquebin31:masterfrom
elpiel wants to merge 2 commits intoquebin31:masterfrom
Conversation
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
quebin31
reviewed
Dec 2, 2022
Comment on lines
109
to
112
| pub fn modification_date(&self) -> DateTime<Utc> { | ||
| let epoch = unsafe { (*self.inner).modificationdate }; | ||
| Utc.timestamp(epoch, 0) | ||
| Utc.timestamp_opt(epoch, 0).unwrap() | ||
| } |
Owner
There was a problem hiding this comment.
Wouldn't be better to return the DateTime<Utc> wrapped inside Option so we avoid unwrap?
Author
There was a problem hiding this comment.
Yes, it would be, however, I wanted to do as little as possible changes to remove the deprecation. Chrono is doing unwrap() anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.