Add UKACM & GACM tutorial: Orchestrating 4C simulations with QUEENS#287
Add UKACM & GACM tutorial: Orchestrating 4C simulations with QUEENS#287reginabuehler wants to merge 1 commit intoqueens-py:mainfrom
Conversation
ef04980 to
351ab6c
Compare
leahaeusel
left a comment
There was a problem hiding this comment.
I apologize in advance for the high number of comments, but don't worry, almost all of them concern small grammar mistakes...
Overall, I really like this tutorial and believe it will be very valuable to future QUEENS users, so thank you for adapting it for our documentation! 🚀
tutorials/3_orchestrating_4c_simulations/3_orchestrating_4c_simulations.ipynb
Show resolved
Hide resolved
tutorials/3_orchestrating_4c_simulations/3_orchestrating_4c_simulations.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
.../4-orchestrating-4C-simulations-with-QUEENS/4_orchestrating_4C_simulations_with_QUEENS.ipynb
Outdated
Show resolved
Hide resolved
leahaeusel
left a comment
There was a problem hiding this comment.
I apologize in advance for the high number of comments, but don't worry, almost all of them concern small grammar mistakes...
Overall, I really like this tutorial and believe it will be very valuable to future QUEENS users, so thank you for adapting it for our documentation! 🚀
tutorials/3_orchestrating_4c_simulations/3_orchestrating_4c_simulations.ipynb
Show resolved
Hide resolved
|
Thanks for the comments and for catching so many details, @leahaeusel! |
f17c566 to
5f8914c
Compare
de9ebd0 to
0144a66
Compare
|
@leahaeusel I addressed all your points. Can you take another look? |
leahaeusel
left a comment
There was a problem hiding this comment.
Changes look good to me, thanks for taking care of it!
sbrandstaeter
left a comment
There was a problem hiding this comment.
It is great to see that the tutorial originally designed by @gilrrei for the UKACM & GACM school can now be merged into main.
Thank you to @gilrrei for the initial design and to @reginabuehler for bringing it to the current state.
Description and Context:
What and Why?
This PR continues the inclusion of tutorials from the UKACM & GACM Autumn School workshop into QUEENS.
It adds the third tutorial
orchestrating-4C-simulations-with-QUEENSinto the QUEENS documentation as4_orchestrating_4C_simulations_with_QUEENSand tests this by including it into the documentation build of the CI pipeline.The content of the tutorial was peer-reviewed during development.
It contains:
pyvistaplots (as opposed to interactive): They run reliably on the CI pipeline and are displayed in the documentation. When running the Jupyter notebook locally they might cause the kernel to crash. This is a known issue from the original draft of the tutorial before the workshop. For now, it is possible to disable thepyvistaplots and refer to the tutorial on the documentation website. In the future, the local behaviour of thepyvistaplots can be improved in a separate PR.Notes during development:
How can
pyvistaplots be handled?pyvistalocally and refer to online tutorial in documentation? (What's the point of running the tutorial locally then?)Miscellaneous notes:
Related Issues and Pull Requests
Interested Parties