Skip to content

Skip chmod in WSL deploy script #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajkessel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip chmod in WSL deploy script #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e7f4f2
Disable chmod permission settings under WSL since it won't work
ajkessel Sep 4, 2025
515bb32
fix typo
ajkessel Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions deploy_ereader.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,13 +451,15 @@ then
fi

# Set proper permissions (Unix-specific)
echo -e "${GREEN}Setting permissions...${NC}"
if command -v chmod >/dev/null 2>&1; then
if ! chmod -R 755 "$DEVICE_PLUGIN_DIR/ereader.koplugin"; then
echo -e "${YELLOW}Warning: Failed to set permissions on plugin directory${NC}"
if [ "${PLATFORM}" != "WSL" ]; then
echo -e "${GREEN}Setting permissions...${NC}"
if command -v chmod >/dev/null 2>&1; then
if ! chmod -R 755 "$DEVICE_PLUGIN_DIR/ereader.koplugin"; then
echo -e "${YELLOW}Warning: Failed to set permissions on plugin directory${NC}"
fi
else
echo -e "${YELLOW}Warning: chmod not available, skipping permission setting${NC}"
fi
else
echo -e "${YELLOW}Warning: chmod not available, skipping permission setting${NC}"
fi

# Cross-platform device ejection
Expand Down
8 changes: 4 additions & 4 deletions plugins/ereader.koplugin/main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,10 +901,10 @@ function Ereader:archiveArticle(article)
UIManager:close(info)

if success then
UIManager:show(InfoMessage:new{
text = (did_enqueue and _("Article will be archived in next sync")) or _("Article archived"),
timeout = 2,
})
-- UIManager:show(InfoMessage:new{
-- text = (did_enqueue and _("Article will be archived in next sync")) or _("Article archived"),
-- timeout = 2,
-- })
-- Refresh the article list
self:showArticles()
else
Expand Down
10 changes: 5 additions & 5 deletions plugins/ereader.koplugin/readerereader.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,10 @@ function ReaderEreader:onArchiveArticle()
UIManager:close(info)

if success then
UIManager:show(InfoMessage:new{
text = (did_enqueue and "Article will be archived in next sync") or "Article archived",
timeout = 2,
})
-- UIManager:show(InfoMessage:new{
-- text = (did_enqueue and "Article will be archived in next sync") or "Article archived",
-- timeout = 2,
-- })
-- Return to articles list
self:onBackToArticles()
else
Expand Down Expand Up @@ -715,4 +715,4 @@ function ReaderEreader:onClose()
end
end

return ReaderEreader
return ReaderEreader