Skip to content

fix: event handler listen to ctx.Done #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GoshaDo merged 5 commits into from
Jan 16, 2025
Merged

fix: event handler listen to ctx.Done #38

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6d1a48
fix: event handler listen to ctx.Done
GoshaDo Jan 9, 2025
d869b7c
fix: event handler listen to ctx.Done
GoshaDo Jan 9, 2025
399a7e6
fix: close piper if watcher down
GoshaDo Jan 11, 2025
aa2b3d6
fix: reduntant use of watcher.stop
GoshaDo Jan 11, 2025
219a530
fix: update
GoshaDo Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions pkg/event_handler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,23 @@ func Start(ctx context.Context, stop context.CancelFunc, cfg *conf.GlobalConfig,
Notifier: notifier,
}
go func() {
for event := range watcher.ResultChan() {
err2 := handler.Handle(ctx, &event)
if err2 != nil {
log.Printf("[event handler] failed to Handle workflow event %s", err2) // ERROR

for {
select {
case <-ctx.Done():
log.Print("[event handler] context canceled, exiting")
watcher.Stop()
return
case event, ok := <-watcher.ResultChan():
if !ok {
log.Print("[event handler] result channel closed")
stop()
return
}
if err2 := handler.Handle(ctx, &event); err2 != nil {
log.Printf("[event handler] failed to handle workflow event: %v", err2)
}
}
}
log.Print("[event handler] stopped work, closing watcher")
Copy link

@adiludmer adiludmer Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoshaDo can explain how the race condition could happen ?

Copy link
Contributor Author

@GoshaDo GoshaDo Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If stop() is called, it will cancel the context (ctx). If the context is already canceled before watcher.Stop() completes, there could be race conditions or unexpected behavior.

Copy link
Contributor Author

@GoshaDo GoshaDo Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok there are no race condition, but it is a good practice to stop the process if the watcher Chanel closed.

watcher.Stop()
stop()
}()
}
Loading