Add Rui Asset type #73
Conversation
|
can RUIP specific functions and structs be moved to its own header? it keeps the asset files less cluttered, and is more inline with similar files such as MSW. more of a preference thing, but personally I'd name the asset file 'ui' like RSX does, not a big hitch but yeah. only main gripes with it currently, I've asked rexx to take a look too. |
Move package to own file Rename rui files to ui
r-ex
left a comment
r-ex
left a comment
There was a problem hiding this comment.
seems good to me! just a few minor formatting changes, otherwise as long as it works i'm happy to merge this. thank you for the implementation!
| <ClInclude Include="public\lcd_screen_effect.h"> | ||
| <Filter>public</Filter> | ||
| </ClInclude> | ||
| <ClInclude Include="public\ruiPackage.h"> |
| pak->AddPointer(hdrChunk,offsetof(RuiHeader_v30_s,renderJobData),renderJobChunk,0); | ||
|
|
||
| asset.InitAsset(hdrChunk.GetPointer(),sizeof(RuiHeader_v30_s), | ||
| PagePtr_t::NullPtr(),30,AssetType::UI); |
There was a problem hiding this comment.
i would prefer if this version num was a define or a constexpr instead of just a magic number - easier to read at a glance
|
|
||
|
|
||
|
|
| {"Ptch", PakAssetScope_e::kAll, Assets::AddPatchAsset, Assets::AddPatchAsset} | ||
| {"Ptch", PakAssetScope_e::kAll, Assets::AddPatchAsset, Assets::AddPatchAsset}, | ||
| {"ui", PakAssetScope_e::kClientOnly, Assets::AddRuiAsset_v30, nullptr} | ||
|
|
| ARIG = TYPE_ARIG, // animation rig | ||
| SHDS = TYPE_SHDS, // shaderset | ||
| SHDR = TYPE_SHDR, // shader | ||
| UI = TYPE_UI |
There was a problem hiding this comment.
| UI = TYPE_UI | |
| UI = TYPE_UI |
| uint16_t val_32; | ||
| }; | ||
|
|
||
|
|
| float elementHeight; | ||
| float elementWidthRcp; | ||
| float elementHeightRcp; | ||
| char* argNames; |
| std::vector<Argument_s> arguments; | ||
| std::vector<ArgCluster_s> argCluster; | ||
| std::vector<char> styleDescriptors; | ||
|
|
| uint32_t renderJobSize; | ||
| uint32_t keyframingSize; | ||
| uint32_t defaultStringsSize; | ||
| uint64_t argNamesOffset;//debug only |
There was a problem hiding this comment.
| uint64_t argNamesOffset;//debug only | |
| uint64_t argNamesOffset; //debug only |
maybe worth separating out offsets from sizes as otherwise this is quite a wall of variables
| #define TYPE_ARIG MAKE_FOURCC('a', 'r', 'i', 'g') // arig | ||
| #define TYPE_SHDS MAKE_FOURCC('s', 'h', 'd', 's') // shds | ||
| #define TYPE_SHDR MAKE_FOURCC('s', 'h', 'd', 'r') // shdr | ||
| #define TYPE_UI MAKE_FOURCC('u', 'i', 0, 0) // ui |
There was a problem hiding this comment.
| #define TYPE_UI MAKE_FOURCC('u', 'i', 0, 0) // ui | |
| #define TYPE_UI MAKE_FOURCC('u', 'i', 0, 0) // ui |
3 participants
Loads rui from RUIP files that are created with SERE
Only support v30 for now