Semgrep test scan 1

.github/workflows/semgrep.yml

@@ -0,0 +1,26 @@
+on:
+  workflow_dispatch: {}
+  pull_request: {}
+  push:
+    branches:
+    - main
+    - master
+    paths:
+    - .github/workflows/semgrep.yml
+  schedule:
+  # random HH:MM to avoid a load spike on GitHub Actions at 00:00
+  - cron: 7 11 * * *
+name: Semgrep
+jobs:
+  semgrep:
+    name: semgrep/ci
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    env:
+      SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
+    container:
+      image: semgrep/semgrep
+    steps:
+    - uses: actions/checkout@v4
+    - run: semgrep ci

src/main/java/org/owasp/benchmark/helpers/DataBaseServer.java

@@ -67,7 +67,7 @@ public ResponseEntity<List<XMLMessage>> getAll(
             org.owasp.benchmark.helpers.DatabaseHelper.printResults(statement, sql, resp);
         } catch (java.sql.SQLException e) {
             if (org.owasp.benchmark.helpers.DatabaseHelper.hideSQLErrors) {
-                e.printStackTrace();
+                //e.printStackTrace();
                 resp.add(new XMLMessage("Error processing request: " + e.getMessage()));
                 return new ResponseEntity<List<XMLMessage>>(resp, HttpStatus.OK);
             } else throw new ServletException(e);

src/main/java/org/owasp/benchmark/helpers/HibernateUtil.java

@@ -185,7 +185,7 @@ public void initData() {
             tx.commit();
         } catch (HibernateException e) {
             if (tx != null) tx.rollback();
-            e.printStackTrace();
+            //e.printStackTrace();
         } finally {
 
         }

src/main/java/org/owasp/benchmark/helpers/LDAPServer.java

@@ -172,7 +172,7 @@ private void initDirectoryService(File workDir) {
             service.startup();
         } catch (Exception e) {
             System.out.println("Error at LDAP startup: " + e.getMessage());
-            e.printStackTrace();
+            //e.printStackTrace();
         }
 
         // Inject the foo root entry if it does not already exist

src/main/java/org/owasp/benchmark/helpers/Startup.java

@@ -38,10 +38,10 @@ public void contextInitialized(ServletContextEvent sce) {
 
         } catch (ClassNotFoundException e) {
             System.out.println("ERROR: Could not find expected DatabaseHelper class.");
-            e.printStackTrace();
+            //e.printStackTrace();
         } catch (Exception e) {
             System.out.println("ERROR: Could not find or add BouncyCastle as crypto provider.");
-            e.printStackTrace();
+            //e.printStackTrace();
         }
 
         if (Security.getProvider("BC") == null)

src/main/java/org/owasp/benchmark/helpers/Utils.java

@@ -104,7 +104,7 @@ public class Utils {
         } catch (ParserConfigurationException e) {
             System.out.println(
                     "ERROR: couldn't set http://apache.org/xml/features/disallow-doctype-decl");
-            e.printStackTrace();
+            //e.printStackTrace();
         }
 
         File tempDir = new File(TESTFILES_DIR);
@@ -116,7 +116,7 @@ public class Utils {
                 out.write("Test is a test file.\n");
                 out.close();
             } catch (FileNotFoundException e) {
-                e.printStackTrace();
+                //e.printStackTrace();
             }
             File testFile2 = new File(TESTFILES_DIR + "SafeText");
             try {

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00006.java

@@ -59,7 +59,13 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
             argList.add("sh");
             argList.add("-c");
         }
-        argList.add("echo " + param);
+        //argList.add("echo " + param);
+        // Sanitize param to only allow alphanumeric characters and spaces. 
+        // Adjust the regex as needed depending on allowed input.
+        param = param.replaceAll("[^a-zA-Z0-9 ]", "");
+
+        argList.add("echo");
+        argList.add(param); // Pass param as a separate argument to avoid command injection
 
         ProcessBuilder pb = new ProcessBuilder();