Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new browser-based Web UI mode to lazytail by introducing a web subcommand that runs an embedded HTTP server and serves a single-page HTML client for browsing/filtering log sources.
Changes:
- Added
webCLI subcommand (WebArgs) and wired it into the main command dispatcher. - Implemented a new
src/webmodule providing an embeddedtiny_httpserver with JSON APIs + SSE-style long-polling. - Added an embedded
index.htmlWeb UI and updated README + dependencies (tiny_http).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/web/mod.rs |
Implements the web server, API routes, state management, filtering, and SSE/eventing. |
src/web/index.html |
Embedded single-page Web UI client with virtualized source/log rendering and controls. |
src/main.rs |
Registers mod web; and dispatches cmd::Commands::Web to web::run. |
src/cmd/mod.rs |
Adds Web subcommand and WebArgs (host/port/files/watch/verbose). |
README.md |
Documents the new lazytail web mode and updates command list. |
Cargo.toml |
Adds tiny_http dependency. |
Cargo.lock |
Locks new transitive deps for tiny_http. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new browser-based Web UI mode to the
lazytaillog viewer, along with the necessary command-line interface and documentation updates. The changes add a newwebsubcommand, argument parsing, and integrate the Web UI into the application startup logic.Web UI feature additions:
tiny_httpdependency inCargo.tomlto support the embedded web server required for the Web UI.WebArgsstruct insrc/cmd/mod.rsfor parsing arguments related to thewebsubcommand (host, port, files, verbosity, etc.).websubcommand to theCommandsenum insrc/cmd/mod.rsand integrated it into the main command dispatch logic insrc/main.rs. [1] [2]webmodule insrc/main.rsto implement the Web UI functionality.Documentation updates:
README.mdto describe the new Web UI mode, including usage instructions and command-line examples. [1] [2] [3]Warning
Binary size almost doubled 🥹