Skip to content

Comments

As 546 upgrading api version#1979

Open
rahulb-rackspace wants to merge 1 commit intorackerlabs:s2i-buildfrom
rahulb-rackspace:AS-546-upgrading-api-version
Open

As 546 upgrading api version#1979
rahulb-rackspace wants to merge 1 commit intorackerlabs:s2i-buildfrom
rahulb-rackspace:AS-546-upgrading-api-version

Conversation

@rahulb-rackspace
Copy link

@rahulb-rackspace rahulb-rackspace commented Dec 14, 2018

No description provided.

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Dec 14, 2018

Can one of the admins verify this patch?

@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Dec 14, 2018

Not right away @awfabian-rs. This PR is logical fix. I need to test it once to verify its sanity. I have created this PR as a place holder for now. Currently trying to get dev environment up and running with autoscale-chef . This might need further changes if something fails.

@rahulb-rackspace rahulb-rackspace force-pushed the AS-546-upgrading-api-version branch 2 times, most recently from b10da35 to ef57dcc Compare January 3, 2019 10:03
@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 1, 2019

jenkins please run unit tests

@rackernexus
Copy link

rackernexus commented Feb 1, 2019

Can one of the admins verify this patch?

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 1, 2019

@rahulb-rackspace

looks like flake8 fails for this one

git diff --patch --no-prefix HEAD^1 | flake8 --diff
./otter/auth.py:63:1: E302 expected 2 blank lines, found 1
./otter/auth.py:384:80: E501 line too long (96 > 79 characters)
./otter/test/test_auth.py:511:80: E501 line too long (82 > 79 characters)
./otter/test/test_auth.py:518:80: E501 line too long (82 > 79 characters)
make: *** [flake8diff] Error 1

can you make changes for this? looks like it doesn't like an extra blank line and a few char line lengths.

trying to see what I can do with the tests on ci, but it stops here

@rahulb-rackspace rahulb-rackspace force-pushed the AS-546-upgrading-api-version branch from c181862 to 217f08c Compare February 5, 2019 09:18
@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 5, 2019

jenkins please run integration tests

10 similar comments
@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 5, 2019

jenkins please run integration tests

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 5, 2019

jenkins please run integration tests

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 5, 2019

jenkins please run integration tests

@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Feb 7, 2019

jenkins please run integration tests

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 8, 2019

jenkins please run integration tests

@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Feb 12, 2019

jenkins please run integration tests

@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Feb 12, 2019

jenkins please run integration tests

@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Feb 12, 2019

jenkins please run integration tests

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 12, 2019

jenkins please run integration tests

@awfabian-rs
Copy link
Contributor

awfabian-rs commented Feb 12, 2019

jenkins please run integration tests

@rahulb-rackspace rahulb-rackspace force-pushed the AS-546-upgrading-api-version branch from 217f08c to f67cf95 Compare March 4, 2019 16:44
@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Mar 7, 2019

jenkins please run unit tests

1 similar comment
@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Mar 11, 2019

jenkins please run unit tests

@rahulb-rackspace rahulb-rackspace force-pushed the AS-546-upgrading-api-version branch from f67cf95 to 50ad5d7 Compare March 11, 2019 08:32
@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Mar 11, 2019

jenkins please run unit tests

@rahulb-rackspace
Copy link
Author

rahulb-rackspace commented Mar 11, 2019

jenkins please run integration tests

@rahulb-rackspace
change otter to not use identity API v1.1
30a7147 
otter uses an identity v1.1 API. They will remove
this on Mar 4, 2019.

Currently v1.1 API version is used to make query for main user
for the tenant.

JIRA => AS-546
URL  => https://jira.rax.io/browse/AS-546
@rahulb-rackspace rahulb-rackspace force-pushed the AS-546-upgrading-api-version branch from 50ad5d7 to 30a7147 Compare March 11, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahulb-rackspace @awfabian-rs @rackernexus