Skip to content

[Snyk] Security upgrade react-router-dom from 5.1.2 to 6.30.2 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebeanogamer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade react-router-dom from 5.1.2 to 6.30.2 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"react-loadable": "^5.5.0",
"react-moment": "^0.9.7",
"react-redux": "^7.2.0",
"react-router-dom": "^5.1.2",
"react-router-dom": "^6.30.2",
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR upgrades react-router-dom from version 5.1.2 to 6.30.3, which is a major version upgrade with significant breaking changes. However, no corresponding code changes are included to handle these breaking changes. The codebase extensively uses React Router v5 APIs that have been removed or changed in v6:

  1. Switch component has been replaced with Routes and has a different API
  2. Route component props have changed (no more 'component' prop, children rendering is different)
  3. Redirect component has been replaced with Navigate component
  4. The 'exact' prop is no longer needed on Routes

This upgrade will break the application at runtime. The PR needs to include migration code for all affected files including:

  • src/controllers/App.js
  • src/controllers/Routes.js
  • src/pages/Campaign.js
  • src/pages/ChallengePage.js
  • src/pages/Lists.js
  • src/pages/TeamPage.js
  • src/plugins/base/auth/components/EmailVerif.js
  • src/plugins/base/auth/components/PasswordReset.js
  • src/plugins/base/auth/components/Teams.js
  • src/plugins/base/auth/components/Welcome.js
  • src/plugins/cms.js

Before merging, all imports and usages of Switch, Route, and Redirect need to be updated to the v6 API.

Suggested change
"react-router-dom": "^6.30.2",
"react-router-dom": "^5.1.2",

Copilot uses AI. Check for mistakes.
"react-simple-code-editor": "^0.11.0",
"react-vis-network": "^1.0.0",
Comment on lines +30 to 32
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in package.json specifies ^6.30.2 but the pnpm-lock.yaml has resolved to 6.30.3. While this is typically acceptable with semver ranges, for security-critical upgrades it's better to have exact alignment. Consider updating package.json to ^6.30.3 to match the locked version.

Suggested change
"react-router-dom": "^6.30.2",
"react-simple-code-editor": "^0.11.0",
"react-vis-network": "^1.0.0",
"react-router-dom": "^6.30.3",
"react-simple-code-editor": "^0.11.0",
"react-vis-network": "^1.0.0",

Copilot uses AI. Check for mistakes.
"redux": "^4.0.5",
Expand Down
Loading
Loading