Add libc version to the binary package name#70
Open
lukeggchapman wants to merge 1 commit intoradarlabs:masterfrom
Open
Add libc version to the binary package name#70lukeggchapman wants to merge 1 commit intoradarlabs:masterfrom
lukeggchapman wants to merge 1 commit intoradarlabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #68
Currently for all node 18 versions it will pull down from the binaries bucket a version compiled with libc 2.29.
This causes a problem with AWS lambda which uses 2.26 at runtime.
This PR should hopefully make the node-pre-gyp package aware of the libc version, and know if it needs to build from scratch or not depending on the desired versions.
Ideally we could come up with a way to build all the different versions and upload them to the binaries bucket. I'm not aware of how this is managed, but happy to contribute where I can.