More robust check for compiler openmp support and enable lto#328
More robust check for compiler openmp support and enable lto#328
Conversation
7cd77b1 to
6211d03
Compare
|
Checking for the specific cpu is annoying for macs - only very recent versions of clang support We also try to use apple Accelerate where openmp isn't available. There's an edge case where blas/lapack calls in a prange cython loop results in Accelerate spawning it's own threads and slowing things down. I'm sure there's a better way around this, but for now I don't think we care too much. I'm open to other suggestions here, though. Finally, I guess it doesn't really matter if we pass all these flags to both the compiler and the linker, so for simplicity I've switched to using a single list. |
73cd2e5 to
b9f6b50
Compare
| name = "caput" | ||
| description = "Cluster Astronomical Python Utilities" | ||
| license = { file = "LICENSE" } | ||
| license = "GPL-2.0-or-later" |
There was a problem hiding this comment.
The old format is deprecated, so we need to update this everywhere. I'm using 2.0 or later here, but if there's an argument to use 2.0 only I'm fine with that as well
There was a problem hiding this comment.
2.0 or later is the right one to use.
7343422 to
46a8e30
Compare
| name = "caput" | ||
| description = "Cluster Astronomical Python Utilities" | ||
| license = { file = "LICENSE" } | ||
| license = "GPL-2.0-or-later" |
There was a problem hiding this comment.
2.0 or later is the right one to use.
46a8e30 to
5af356e
Compare
No description provided.