fix(astro.constants): Redefine t_sidereal#336
Merged
ketiltrout merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
ljgray
approved these changes
Mar 12, 2026
The previous definition of `t_sidereal` was defined in in terms of a magic number of SI hours. Instead, let's directly define it in terms of the `sidereal_second` that we already have. The difference between the new definition and the old is small: ``` (sidereal_second * day) / old_t_sidereal - 1 = 1.7114933914541552e-09 ``` or less than 0.2 millisconds per day.
ketiltrout
force-pushed
the
redefine_t_sidereal
branch
from
1391cd1 to
49f5c90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous definition of
t_siderealwas defined in in terms of a magic number of SI hours. Instead, let's directly define it in terms of thesidereal_secondthat we already have.The difference between the new definition and the old is small:
or less than 0.2 millisconds per day.