Open
Conversation
tristpinsm
force-pushed
the
tpm/lyalpha
branch
2 times, most recently
from
7c8599c to
836af4c
Compare
jrs65
requested changes
Nov 5, 2022
Contributor
jrs65
left a comment
jrs65
left a comment
There was a problem hiding this comment.
I'm still going, but here are some first round comments.
| return data_exp | ||
|
|
||
|
|
||
| class GaussianNoiseExternal(task.SingleTask, random.RandomTask): |
Contributor
There was a problem hiding this comment.
It seems like this could be done by using the existing tasks GaussianNoise to generate a realisation and then MixData to combine them, rather than adding an extra task?!
Contributor
Author
There was a problem hiding this comment.
yeah I guess so, I hadn't thought of using MixData
tristpinsm
force-pushed
the
tpm/lyalpha
branch
from
3e4d5df to
836af4c
Compare
tristpinsm
force-pushed
the
tpm/lyalpha
branch
3 times, most recently
from
87942f3 to
2c38660
Compare
Contributor
Author
|
OK, I've addressed most of Richard's comments now and also added some new tasks to perform the cross-correlations and make permutations of spectra. |
tristpinsm
force-pushed
the
tpm/lyalpha
branch
from
3bba7fb to
80baba3
Compare
tristpinsm
force-pushed
the
tpm/lyalpha
branch
from
75b6a32 to
106ff55
Compare
Task for adding noise scaled by the weights of an external dataset.
Also adds core.io.LoadFITSCatalogDLA, which extracts DLA positions.
Normalise the FFT cross-correlation method to be consistent with the direct evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm about to start writing the paper up for this analysis, so I thought it would be good to also get the code reviewed and merged.