refactor(ConstructWienerDelayTransform): Distribute over RA.#367
Draft
tristpinsm wants to merge 1 commit intomainfrom
Draft
refactor(ConstructWienerDelayTransform): Distribute over RA.#367tristpinsm wants to merge 1 commit intomainfrom
tristpinsm wants to merge 1 commit intomainfrom
Conversation
tristpinsm
force-pushed
the
tpm/wiener-fast
branch
from
87db66f to
ab374aa
Compare
This makes it possible to construct an operator that is independent of elevation.
tristpinsm
force-pushed
the
tpm/wiener-fast
branch
from
ab374aa to
d4030cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this to solicit comments / feedback.
I changed the distribution axis to
raso that I could try generating the transform independently ofel, and apply it to a larger area of the ringmap without running into cumbersome memory (and I/O if writing out the operator) requirements. In this configuration, it ignores the dirty beam scaling to the signal prior, and takes an average of the weights acrosselto estimate the noise covariance. I'm not sure if the latter step is the best thing to do, as it may be sensitive to outlier elevations, especially if the full extent is included?