Skip to content

Add --set flags to rad upgrade kubernetes in long-running test workflow#11219

Open
willdavsmith wants to merge 4 commits intoradius-project:mainfrom
willdavsmith:021026-lrt-fix
Open

Add --set flags to rad upgrade kubernetes in long-running test workflow#11219
willdavsmith wants to merge 4 commits intoradius-project:mainfrom
willdavsmith:021026-lrt-fix

Conversation

@willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Feb 11, 2026

Description

Add --set flags to rad upgrade kubernetes in long-running test workflow. This is to address a bug/existing behavior in rad upgrade kubernetes where this command will not persist previously-applied --set flags.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

#11218

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@willdavsmith
add --sets to upgrade
de789e9 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith willdavsmith requested review from a team as code owners February 11, 2026 01:26
@willdavsmith willdavsmith temporarily deployed to external-contributor-approval February 11, 2026 01:26 — with GitHub Actions Inactive
Copilot AI reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a workaround for a known limitation in rad upgrade kubernetes where Helm chart values from the previous release are not automatically reused during upgrades. The change ensures that critical configuration values (global.azureWorkloadIdentity.enabled=true and database.enabled=true) are explicitly re-applied during control plane upgrades in the long-running Azure test workflow, preventing them from silently resetting to their chart defaults.

Changes:

  • Modified .github/scripts/manage-radius-installation.sh to pass --set flags when executing rad upgrade kubernetes

@brooke-hamilton brooke-hamilton temporarily deployed to external-contributor-approval February 11, 2026 13:45 — with GitHub Actions Inactive
@willdavsmith willdavsmith requested a deployment to external-contributor-approval February 12, 2026 16:54 — with GitHub Actions Waiting
@willdavsmith willdavsmith temporarily deployed to external-contributor-approval February 24, 2026 00:14 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 24, 2026 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository willdavsmith/radius
Commit ref 7962b17
Unique ID func2eeab3b7ac
Image tag pr-func2eeab3b7ac
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2eeab3b7ac
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2eeab3b7ac
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2eeab3b7ac
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func2eeab3b7ac
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2eeab3b7ac
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Test tool installation for corerp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ Test tool installation for ucp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Test tool installation for ucp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ Test tool installation for corerp-cloud failed. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.00%. Comparing base (088b1fe) to head (7962b17).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11219      +/-   ##
==========================================
- Coverage   51.00%   51.00%   -0.01%     
==========================================
  Files         679      679              
  Lines       43174    43174              
==========================================
- Hits        22023    22021       -2     
- Misses      19033    19034       +1     
- Partials     2118     2119       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@nicolejms nicolejms nicolejms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@willdavsmith @brooke-hamilton @nicolejms