Update radius to setup default recipepack during rad init and env operations. by nithyatsu · Pull Request #11294 · radius-project/radius

nithyatsu · 2026-02-24T00:13:14Z

Description

rad init

uses Radius.Core API
creates default pack in default and injects it into default environment

rad env create --preview

adds default recipe pack when creating a new Radius.Core environment

rad deploy

before deploying, scans the compiled ARM template for all Radius.Core/environments.
For each environment found, inspects existing recipe packs, if none, adds default pack.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #11091

radius-project/resource-types-contrib#100 and this PR must be merged together.

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

Signed-off-by: nithyatsu <nithyasu@microsoft.com> rad init implementation Signed-off-by: nithyatsu <nithyasu@microsoft.com> name default pack Signed-off-by: nithyatsu <nithyasu@microsoft.com> add tests Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> rad init cahnges Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> renames Signed-off-by: nithyatsu <nithyasu@microsoft.com> create upadtes Signed-off-by: nithyatsu <nithyasu@microsoft.com> update Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> deploy changes Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> refactor + comments Signed-off-by: nithyatsu <nithyasu@microsoft.com> deploy fix Signed-off-by: nithyatsu <nithyasu@microsoft.com> fix Signed-off-by: nithyatsu <nithyasu@microsoft.com> remove dev recipe test Signed-off-by: nithyatsu <nithyasu@microsoft.com> wip Signed-off-by: nithyatsu <nithyasu@microsoft.com> ci: retrigger ci: retrigger ci: retrigger

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

Copilot

Pull request overview

Updates the Radius CLI to ensure a default Radius.Core recipe pack is created (in the fixed default scope) and attached to environments during rad init, rad env create --preview, and rad deploy, aligning environment setup and deployments with the newer Radius.Core API surface.

Changes:

Introduce a pkg/cli/recipepack package to define/create the default Kubernetes core recipe pack and IDs.
Update rad init and rad env create --preview to create the default recipe pack and attach it to newly created Radius.Core environments.
Update rad deploy to scan compiled templates for Radius.Core environments and inject the default recipe pack when none are specified, with expanded fake servers/tests.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/functional-portable/cli/noncloud/testdata/corerp-recipe-pack-test.bicep	Adjusts recipe pack test template contents.
test/functional-portable/cli/noncloud/cli_test.go	Removes DevRecipes functional test that created env directly.
pkg/cli/test_client_factory/radius_core.go	Expands Radius.Core fake servers (404-on-get env/packs, create/update handlers, type-mapping helpers).
pkg/cli/recipepack/recipepack.go	Adds default recipe pack definition, IDs, and default RG scope helpers.
pkg/cli/recipepack/recipepack_test.go	Adds unit tests for default recipe pack definitions and resource construction.
pkg/cli/cmd/utils.go	Adds helper to build RecipePacksClients per referenced scope.
pkg/cli/cmd/utils_test.go	Adds tests for the new PopulateRecipePackClients helper.
pkg/cli/cmd/radinit/options.go	Switches computed workspace environment ID to Radius.Core provider namespace.
pkg/cli/cmd/radinit/options_test.go	Updates expectations to match Radius.Core environment IDs.
pkg/cli/cmd/radinit/init.go	Extends runner with Radius.Core client factories (workspace + default scope).
pkg/cli/cmd/radinit/init_test.go	Updates init tests to use Radius.Core test client factory and reflect extra RG creation call.
pkg/cli/cmd/radinit/environment.go	Creates Radius.Core environment, ensures default RG exists, creates default recipe pack, and attaches it.
pkg/cli/cmd/env/create/preview/create.go	Creates Radius.Core environment and attaches default recipe pack during preview env creation.
pkg/cli/cmd/env/create/preview/create_test.go	Updates preview env-create tests for default recipe pack behavior and output.
pkg/cli/cmd/deploy/deploy.go	Adds deploy-time default recipe pack injection for Radius.Core environments in compiled templates.
pkg/cli/cmd/deploy/deploy_test.go	Adds tests covering recipe pack injection/no-op paths and default-pack creation behavior.

Copilot · 2026-02-24T00:18:15Z

pkg/cli/cmd/utils.go

+		// This is the bicep reference for id, and cannot be invalid.
+		packID, _ := resources.Parse(packIDStr)


Don't ignore the error from resources.Parse(packIDStr). If packIDStr is malformed (or an ARM/Bicep expression), Parse will fail and RootScope() will produce an incorrect scope (often "/"), leading to clients being created against the wrong scope. Return a clear error (or skip/handle expression IDs explicitly) when Parse fails.

Suggested change

// This is the bicep reference for id, and cannot be invalid.

packID, _ := resources.Parse(packIDStr)

// This is expected to be a valid bicep reference for id, but we still

// validate and fail fast if parsing does not succeed to avoid using

// an incorrect default scope.

packID, err := resources.Parse(packIDStr)

if err != nil {

return fmt.Errorf("failed to parse recipe pack ID %q: %w", packIDStr, err)

}

Copilot · 2026-02-24T00:18:15Z

pkg/cli/cmd/radinit/environment.go

+	defaultPack := recipepack.NewDefaultRecipePackResource()
+	_, err = r.DefaultScopeClientFactory.NewRecipePacksClient().CreateOrUpdate(ctx, recipepack.DefaultRecipePackResourceName, defaultPack, nil)
+	if err != nil {
+		return clierrors.MessageWithCause(err, "Failed to create default recipe pack.")
+	}


Creating the default recipe pack via CreateOrUpdate on every init run can overwrite user modifications to an existing "default" pack in the default scope. Prefer a GET-first flow (create only on 404) or use an ETag/If-Match strategy so init doesn't clobber an existing pack unexpectedly.

Copilot · 2026-02-24T00:18:15Z

pkg/cli/cmd/env/create/preview/create.go

+	defaultPack := recipepack.NewDefaultRecipePackResource()
+	_, err = r.DefaultScopeClientFactory.NewRecipePacksClient().CreateOrUpdate(ctx, recipepack.DefaultRecipePackResourceName, defaultPack, nil)
+	if err != nil {
+		return err
+	}


Creating the default recipe pack with CreateOrUpdate unconditionally can overwrite an existing user-customized "default" pack in the default scope. Prefer checking for existence (GET + create on 404) before writing, consistent with the deploy path's get-or-create behavior.

Copilot · 2026-02-24T00:18:15Z

pkg/cli/cmd/radinit/environment.go

+	envProperties := corerpv20250801.EnvironmentProperties{
+		Providers: providers,
 	}

-	var recipes map[string]map[string]corerp.RecipePropertiesClassification
-	if r.Options.Recipes.DevRecipes {
-		// Note: To use custom registry for recipes, users need to manually configure
-		// their environment after initialization or use custom recipe definitions
-		recipes, err = r.DevRecipeClient.GetDevRecipes(ctx)
+	// Initialize the Radius.Core client factory if not already set
+	if r.RadiusCoreClientFactory == nil {
+		clientFactory, err := cmd.InitializeRadiusCoreClientFactory(ctx, r.Workspace, r.Workspace.Scope)
 		if err != nil {
-			return err
+			return clierrors.MessageWithCause(err, "Failed to initialize Radius Core client.")
 		}
+		r.RadiusCoreClientFactory = clientFactory
 	}


rad init still sets/prints options.Recipes.DevRecipes (and Runner still carries DevRecipeClient), but CreateEnvironment no longer uses either to influence the created environment. Either remove the dev-recipes option/UI/fields or reintroduce equivalent behavior using the new Radius.Core recipe pack model so the option isn't a no-op.

Copilot · 2026-02-24T00:18:16Z

pkg/cli/cmd/radinit/init.go

 	// DevRecipeClient is the interface for the dev recipe client.
 	DevRecipeClient DevRecipeClient

+	// RadiusCoreClientFactory is the client factory for Radius.Core resources.
+	// If nil, it will be initialized during Run.
+	RadiusCoreClientFactory *corerpv20250801.ClientFactory
+
+	// DefaultScopeClientFactory is the client factory scoped to the default resource group.
+	// Singleton recipe packs are always created/queried in the default scope.
+	DefaultScopeClientFactory *corerpv20250801.ClientFactory
+


Runner.DevRecipeClient appears to be unused now that environment creation no longer applies dev recipes. Consider removing this field (and related wiring) or updating the new recipe-pack-based flow to use it, to avoid dead code and misleading configuration surface.

Suggested change

// DevRecipeClient is the interface for the dev recipe client.

DevRecipeClient DevRecipeClient

// RadiusCoreClientFactory is the client factory for Radius.Core resources.

// If nil, it will be initialized during Run.

RadiusCoreClientFactory *corerpv20250801.ClientFactory

// DefaultScopeClientFactory is the client factory scoped to the default resource group.

// Singleton recipe packs are always created/queried in the default scope.

DefaultScopeClientFactory *corerpv20250801.ClientFactory

// RadiusCoreClientFactory is the client factory for Radius.Core resources.

// If nil, it will be initialized during Run.

RadiusCoreClientFactory *corerpv20250801.ClientFactory

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

codecov · 2026-02-25T17:38:45Z

Codecov Report

❌ Patch coverage is 31.26685% with 255 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.79%. Comparing base (088b1fe) to head (e204475).

Files with missing lines	Patch %	Lines
pkg/cli/test_client_factory/radius_core.go	0.00%	182 Missing ⚠️
pkg/cli/cmd/deploy/deploy.go	53.94%	20 Missing and 15 partials ⚠️
pkg/cli/cmd/radinit/environment.go	51.51%	12 Missing and 4 partials ⚠️
pkg/cli/cmd/env/create/preview/create.go	52.17%	7 Missing and 4 partials ⚠️
pkg/cli/recipepack/recipepack.go	84.61%	6 Missing ⚠️
pkg/cli/cmd/utils.go	63.63%	4 Missing ⚠️
pkg/cli/cmd/env/update/preview/update.go	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11294      +/-   ##
==========================================
- Coverage   51.00%   50.79%   -0.22%     
==========================================
  Files         679      680       +1     
  Lines       43174    43508     +334     
==========================================
+ Hits        22023    22098      +75     
- Misses      19033    19267     +234     
- Partials     2118     2143      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nithyatsu added 16 commits February 23, 2026 16:08

update rad install

33c9757

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

check default rg

c949d38

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

10ee0ce

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

update tests

5df98db

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

aaf64e4

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

refactor

4ca973a

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

fix for recipepack reference from template

67c7d0f

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

Update rad init

6e95956

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

remove changes to update

c904431

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

rad init updates

0f24bf9

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

update env create

f3d8c7b

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

add comments - deploy

933cb9c

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

update create -refactor

2ec7656

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

da4a68d

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

b00a62a

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

nithyatsu requested a review from a team as a code owner February 24, 2026 00:13

Copilot AI review requested due to automatic review settings February 24, 2026 00:13

nithyatsu requested a review from a team as a code owner February 24, 2026 00:13

nithyatsu requested a deployment to external-contributor-approval February 24, 2026 00:13 — with GitHub Actions Waiting

Copilot started reviewing on behalf of nithyatsu February 24, 2026 00:13 View session

nithyatsu mentioned this pull request Feb 24, 2026

add workflow to publish radius core type bicep recipes as part of release process radius-project/resource-types-contrib#100

Open

17 tasks

Copilot AI reviewed Feb 24, 2026

View reviewed changes

rad env update changes

e204475

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

nithyatsu requested a deployment to external-contributor-approval February 25, 2026 17:25 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update radius to setup default recipepack during rad init and env operations.#11294

Update radius to setup default recipepack during rad init and env operations.#11294
nithyatsu wants to merge 17 commits intoradius-project:mainfrom
nithyatsu:setupdefaultpack

nithyatsu commented Feb 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

codecov bot commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// This is the bicep reference for id, and cannot be invalid.
		packID, _ := resources.Parse(packIDStr)

-		// This is the bicep reference for id, and cannot be invalid.
-		packID, _ := resources.Parse(packIDStr)
+		// This is expected to be a valid bicep reference for id, but we still
+		// validate and fail fast if parsing does not succeed to avoid using
+		// an incorrect default scope.
+		packID, err := resources.Parse(packIDStr)
+		if err != nil {
+			return fmt.Errorf("failed to parse recipe pack ID %q: %w", packIDStr, err)
+		}

Conversation

nithyatsu commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 25, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nithyatsu commented Feb 24, 2026 •

edited

Loading