feat: init commit #1
Conversation
|
No linked issues found. Please add the corresponding issues in the pull request description. |
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial implementation of rsdk-image, a Debian package that bundles a pre-built Docker image for offline distribution and use. The package includes scripts to run and manage the containerized Radxa SDK environment.
Key changes:
- Implements Docker image packaging infrastructure with build/install scripts
- Adds GitHub Actions workflow for automated multi-architecture builds (amd64/arm64)
- Provides documentation in both English and Chinese
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/run-rsdk-image.sh |
Script to launch the Docker container with appropriate mounts and options |
scripts/install-rsdk.sh |
In-container script for installing rsdk with optional Chinese mirror support |
rsdk |
Git submodule reference to the rsdk repository |
debian/rules |
Debian packaging rules that build and bundle the Docker image |
debian/postinst |
Post-installation script to load the Docker image |
debian/control |
Package metadata and dependencies |
README_zh.md |
Chinese documentation |
README.md |
English documentation |
Dockerfile |
Docker image definition for Debian 12 with rsdk build environment |
.gitmodules |
Git submodule configuration |
.github/workflows/release.yaml |
CI/CD workflow for building and releasing packages |
Comments suppressed due to low confidence (1)
debian/rules:1
- The sed substitution pattern uses VERSION as a literal string but should escape special characters in the version string obtained from dpkg-parsechangelog, as version strings may contain characters with special meaning in sed (e.g.,
/,&). Consider using a delimiter other than/or properly escaping the version string.
#!/usr/bin/make -f
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scripts/install-rsdk.sh
Outdated
|
|
||
| # Auto-detect if in China network if -c not specified | ||
| if [ "$USE_CN_MIRROR" -eq 0 ]; then | ||
| if ! curl -s google.com | grep -q "301 Moved"; then |
There was a problem hiding this comment.
The curl command lacks a protocol scheme. Should be curl -s https://google.com or curl -s http://google.com to function correctly.
| if ! curl -s google.com | grep -q "301 Moved"; then | |
| if ! curl -s http://google.com | grep -q "301 Moved"; then |
There was a problem hiding this comment.
不要改我们自带的workflow吧，这些会被模板覆盖的。先看看你的编译功能能不能通过make deb去实现
There was a problem hiding this comment.
第一个版本想过是通过buildx 实现出arm64镜像，但是dpkg那边不是很好处理，除非我打all包 在安装的时候区分架构，但是显然不合适
There was a problem hiding this comment.
包的arch应该编译时可以通过DEB_BUILD_ARCH获得，镜像编译脚本可以通过这个来进行区分。然后可以在debuild的时候传入不同的-a参数从而编译不同的包。
不过这个涉及到了交叉编译还有原生编译等一系列问题。我们目前大多数包其实都只处理了x64交叉编译这一个场景，所以模板还有别的基础架构都不是很完善。我觉得目前第一版还是也先只考虑x64镜像好了。
There was a problem hiding this comment.
- 参考我们其他脚本处理输出参数
- 参考我们其他脚本加上DEBHELPER的占位符
- control里面已经定义成arch any了，为什么这个包还会装不同arch的镜像？
| IMAGE_NAME ?= rsdk-image | ||
|
|
||
| # This file is auto generated by rsdk infra-package-update. | ||
| # DO NOT EDIT IT DIRECTLY! |
There was a problem hiding this comment.
模板管理的，别动了。另外模板有mdbook的支持，可以把文档放那边写。可以参考rsetup，那边做了i18n
README.md
Outdated
| 1. `git clone --recurse-submodules https://github.com/radxa-pkg/rsdk-image.git` | ||
| 2. Open in [`devcontainer`](https://code.visualstudio.com/docs/devcontainers/containers) | ||
| 3. `make deb` | ||
| Download the latest `.deb` package from the [Releases](https://github.com/xzl01/rsdk-image/releases) page. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
另外提交code suggestion可以在PR的files changed标签里面批量选择然后一次性提交 |
2 participants
No description provided.