Skip to content

Fixed classes collection when library is build as a framework #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanSkeel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed classes collection when library is build as a framework #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions BloodMagic/Sources/Modules/Core/Private/Collectors/BMClassCollector.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,14 @@ - (void)dealloc

- (void)collectClasses
{
#ifdef __IPHONE_OS_VERSION_MIN_REQUIRED
uint classesCount;
const char *imageName = class_getImageName(object_getClass(self));
const char **classNames = objc_copyClassNamesForImage(imageName, &classesCount);
for (uint index = 0; index < classesCount; index++) {
Class nextClass = objc_getClass(classNames[index]);
_cachedClasses.push_back(nextClass);
}
free(classNames);
#else
Class parentClass = [NSObject class];

int numClasses = objc_getClassList(NULL, 0);

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wvla-extension"
Class classes[sizeof(Class) * numClasses];
#pragma clang diagnostic pop

if (numClasses == 0) return;

Class *classes = (Class *)malloc(sizeof(Class) * numClasses);
numClasses = objc_getClassList(classes, numClasses);

for (NSInteger i = 0; i < numClasses; i++) {
Class superClass = classes[i];
do {
Expand All @@ -76,7 +65,7 @@ - (void)collectClasses
}
_cachedClasses.push_back(klass);
}
#endif
free(classes);
}

- (class_list_t *)collectForProtocol:(Protocol *)protocol
Expand Down