feat: show oracle info on order detail page (Phase 4)#2459
Open
hardyjosh wants to merge 1 commit intofeat/signed-context-oracle-fetchfrom
Open
feat: show oracle info on order detail page (Phase 4)#2459hardyjosh wants to merge 1 commit intofeat/signed-context-oracle-fetchfrom
hardyjosh wants to merge 1 commit intofeat/signed-context-oracle-fetchfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hardyjosh
pushed a commit
that referenced
this pull request
Feb 16, 2026
Adds optional oracle-url field to OrderCfg, parsed from the YAML front matter orders section. When present, this URL identifies a signed context oracle server for the order. Changes: - Add oracle_url: Option<String> to OrderCfg struct - Parse oracle-url via optional_string in YAML parsing - Add oracle-url to ALLOWED_ORDER_KEYS - Update Default and PartialEq impls - Add test for oracle-url parsing (present + absent) Spec: rainlanguage/specs#45 Chained on: #2459 (Phase 4)
4 tasks
hardyjosh
force-pushed
the
feat/signed-context-oracle-fetch
branch
from
929dcff to
1d940d3
Compare
hardyjosh
force-pushed
the
feat/signed-context-oracle-ui
branch
from
b349274 to
e375cee
Compare
hardyjosh
pushed a commit
that referenced
this pull request
Feb 17, 2026
Adds optional oracle-url field to OrderCfg, parsed from the YAML front matter orders section. When present, this URL identifies a signed context oracle server for the order. Changes: - Add oracle_url: Option<String> to OrderCfg struct - Parse oracle-url via optional_string in YAML parsing - Add oracle-url to ALLOWED_ORDER_KEYS - Update Default and PartialEq impls - Add test for oracle-url parsing (present + absent) Spec: rainlanguage/specs#45 Chained on: #2459 (Phase 4)
hardyjosh
force-pushed
the
feat/signed-context-oracle-fetch
branch
from
1d940d3 to
63ea51f
Compare
hardyjosh
force-pushed
the
feat/signed-context-oracle-ui
branch
from
e375cee to
10a7183
Compare
hardyjosh
pushed a commit
that referenced
this pull request
Feb 22, 2026
Adds optional oracle-url field to OrderCfg, parsed from the YAML front matter orders section. When present, this URL identifies a signed context oracle server for the order. Changes: - Add oracle_url: Option<String> to OrderCfg struct - Parse oracle-url via optional_string in YAML parsing - Add oracle-url to ALLOWED_ORDER_KEYS - Update Default and PartialEq impls - Add test for oracle-url parsing (present + absent) Spec: rainlanguage/specs#45 Chained on: #2459 (Phase 4)
hardyjosh
force-pushed
the
feat/signed-context-oracle-ui
branch
from
57bb022 to
5963780
Compare
hardyjosh
pushed a commit
that referenced
this pull request
Feb 23, 2026
Adds optional oracle-url field to OrderCfg, parsed from the YAML front matter orders section. When present, this URL identifies a signed context oracle server for the order. Changes: - Add oracle_url: Option<String> to OrderCfg struct - Parse oracle-url via optional_string in YAML parsing - Add oracle-url to ALLOWED_ORDER_KEYS - Update Default and PartialEq impls - Add test for oracle-url parsing (present + absent) Spec: rainlanguage/specs#45 Chained on: #2459 (Phase 4)
JuaniRios
approved these changes
Feb 24, 2026
hardyjosh
force-pushed
the
feat/signed-context-oracle-ui
branch
from
5963780 to
7fb4b52
Compare
hardyjosh
pushed a commit
that referenced
this pull request
Feb 24, 2026
Adds optional oracle-url field to OrderCfg, parsed from the YAML front matter orders section. When present, this URL identifies a signed context oracle server for the order. Changes: - Add oracle_url: Option<String> to OrderCfg struct - Parse oracle-url via optional_string in YAML parsing - Add oracle-url to ALLOWED_ORDER_KEYS - Update Default and PartialEq impls - Add test for oracle-url parsing (present + absent) Spec: rainlanguage/specs#45 Chained on: #2459 (Phase 4)
findolor
requested changes
Mar 3, 2026
Collaborator
findolor
left a comment
findolor
left a comment
There was a problem hiding this comment.
do you think that we can update the order detail tests for the UI changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Merge order: Merge #2458 first, then this PR.
Motivation
Orders with signed context oracles should visually indicate this to users. Currently there is no UI signal that an order uses external oracle data for its quotes.
Solution
oracleUrlexists, displayed as clickable link with info tooltipChecks
By submitting this for review, I'm confirming I've done the following: