Skip to content

Comments

[stale] Add licence summary#80

Merged
tommaitland merged 5 commits intoraisely:publishfrom
realpixelcode:pixelcode-summary
Sep 16, 2022
Merged

[stale] Add licence summary#80
tommaitland merged 5 commits intoraisely:publishfrom
realpixelcode:pixelcode-summary

Conversation

@realpixelcode
Copy link
Contributor

Adds an easy-to-understand summary of the licence. Fixes #72.

@ghost
Copy link

ghost commented Jul 27, 2022

Just read it. Very concise and digestible. Now I bet the core team is going to probably ask on how to integrate it into the main license for ease of access, or probably include a reference in the README.md.

@realpixelcode
Copy link
Contributor Author

Just read it. Very concise and digestible. Now I bet the core team is going to probably ask on how to integrate it into the main license for ease of access, or probably include a reference in the README.md.

Just added a link to the README.md :)

@ghost
Copy link

ghost commented Jul 28, 2022

@realpixelcode, I was just rereading your license summary, and I was thinking that if this PR gets merged before mine (#79), I think I could possibly make a template for the summary as well (I would have to ask the core team because it would require different API). What do you think?

@realpixelcode
Copy link
Contributor Author

In principle, I find that a good idea, I'm just wondering how you would do that? A script would most likely not be sufficiently "intelligent" enough to generate a summary out of a new licence text itself.

@ghost
Copy link

ghost commented Jul 28, 2022

I mean to modify the existing context to build the summary from its own template. This is much more simpler than machine learning.

@realpixelcode
Copy link
Contributor Author

Ok, go ahead then, I guess 😊

@ghost
Copy link

ghost commented Jul 28, 2022

Sorry for the late response. I thought I responded earlier.

@ghost
Copy link

ghost commented Jul 28, 2022

(edited for grammar)

Still waiting for review from the core team. They may not want to "template-ify" the summary.

@realpixelcode
Copy link
Contributor Author

Sorry for the late response. I thought I responded earlier.

No worries, mate :) Aren't we multiple time zones apart anyway? 😄 Also, others take much longer. 🤷

@ghost
Copy link

ghost commented Sep 16, 2022

Hello @realpixelcode. I can see that this PR is not getting merged; the same is happening for me, so I decided to prefix the title my PR (#79 ) with [Stale!], and I'm thinking about closing it entirely and keeping the branch for when someone wants to re-open it.

@realpixelcode realpixelcode changed the title Add licence summary [stale] Add licence summary Sep 16, 2022
@ghost ghost mentioned this pull request Sep 16, 2022
Copy link
Contributor

@tommaitland tommaitland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, thanks for the contribution!

@tommaitland tommaitland merged commit 736d735 into raisely:publish Sep 16, 2022
@realpixelcode
Copy link
Contributor Author

Sorry for the delay here, thanks for the contribution!

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a summary?

2 participants