Add support for file request paging to Remote::FindParentById#24
Add support for file request paging to Remote::FindParentById#24arolett2 wants to merge 1 commit intorakyll:masterfrom arolett2:master
Conversation
|
We should have a better and interactive pagination strategy. We shouldn't stall if a directory contains too many children. |
|
Thanks for taking a look! For the internal API flow are you imagining FindParentByIdFirst/Next/Close flow for the API? For a pull request it seems like we need to know all of the files for changes.go so we can figure out what to sync down. But I see how we could improve things by processing the changes in batches. I'll take a look a bit later. |
|
Sorry for catching up so lately. The more pleasant behavior is to have interactive cursoring, so the user can cancel on any time. But it will require some more work, will break some upcoming features as well. So, let's merge this PR first and I'll make improvements on the top this change. |
remote.go
Outdated
There was a problem hiding this comment.
There is a flag now that allows you not to ignore the hidden files. Could you honor that?
While issuing pull requests on a few of my directories I noticed that I was missing files. Implement paging so pull requests on directories that have more than 100 files work.
While issuing pull requests on a few of my directories I noticed that
I was missing files. Implement paging so pull requests on directories
that have more than 100 files work.