This repository was archived by the owner on Sep 3, 2020. It is now read-only.
Use GOOGLE_API_CLIENT_ID and GOOGLE_API_CLIENT_SECRET#35
Open
ccmaymay wants to merge 4 commits intorakyll:masterfrom
Open
Use GOOGLE_API_CLIENT_ID and GOOGLE_API_CLIENT_SECRET#35ccmaymay wants to merge 4 commits intorakyll:masterfrom
ccmaymay wants to merge 4 commits intorakyll:masterfrom
Conversation
README.md
Outdated
Owner
There was a problem hiding this comment.
Please use these values if there are set. If not, fallback to the embedded credentials.
…oth set in the environment
|
|
||
| g.context.ClientId = os.Getenv(clientIDEnvKey) | ||
| g.context.ClientSecret = os.Getenv(clientSecretEnvKey) | ||
| if len(g.context.ClientId) == 0 || len(g.context.ClientSecret) == 0 { |
Owner
There was a problem hiding this comment.
g.context.ClientID == "" || g.context.C
varga199
approved these changes
Jul 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi rakyll,
Thanks for writing the drive tool---it's very nice. :) I changed Init() to read GOOGLE_API_CLIENT_ID and GOOGLE_API_CLIENT_SECRET, respectively, from the environment. If either is empty, an error is returned. This is minimalistic, and won't work for everyone, but if you like it feel free to merge. (This is also my first foray into go so it may not be very idiomatic!)
Chandler