Support for configuration of color for skipped tests via environment variable#17
Open
jonasbn wants to merge 8 commits intorakyll:masterfrom
Open
Support for configuration of color for skipped tests via environment variable#17jonasbn wants to merge 8 commits intorakyll:masterfrom
jonasbn wants to merge 8 commits intorakyll:masterfrom
Conversation
…nfiguration using the environment variable
subtlepseudonym
suggested changes
May 18, 2020
Contributor
subtlepseudonym
left a comment
subtlepseudonym
left a comment
There was a problem hiding this comment.
A few nitpicky copy changes (not blockers) and one code change
More correct and explicit naming used Co-authored-by: Connor Demille <subtlepseudonym@gmail.com>
subtlepseudonym
suggested changes
May 21, 2020
Co-authored-by: Connor Demille <subtlepseudonym@gmail.com>
subtlepseudonym
approved these changes
May 21, 2020
Contributor
Author
|
Updated from master with the latest releases, conflicts resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have made an attempt at support for configuration of the color for skipped tests using the environment variable as a third parameter.
I have also updated the documentation since I thought it was a bit sparse.
I am very new to Go so please bare with me if I have made some basic mistakes. I hope you will consider my mediocre contribution.