cmd: add -a option to allow inclusion of hidden files#113
cmd: add -a option to allow inclusion of hidden files#113yskopets wants to merge 1 commit intorakyll:masterfrom
-a option to allow inclusion of hidden files#113Conversation
|
|
||
| -ns The namespace where assets will exist, "default" by default. | ||
| -f Override destination if it already exists, false by default. | ||
| -a Include hidden files, false by default. |
There was a problem hiding this comment.
I like the -a (like in ls) tho I'd prefer to use [their description])(https://linux.die.net/man/1/ls):
-a, --all
do not ignore entries starting with .
What do you think?
There was a problem hiding this comment.
yeah, sounds great. I will update it.
| flagNamespace = flag.String("ns", "default", "") | ||
| flagPkgCmt = flag.String("c", "", "") | ||
| flagInclude = flag.String("include", "*.*", "") | ||
| flagAllFiles = flag.Bool("a", false, "") |
There was a problem hiding this comment.
I'd change it into flagIgnoreDotFiles to be more inline with its real purpose.
There was a problem hiding this comment.
I think, the name flagIgnoreDotFiles has a meaning opposite to -a ("do not ignore entries starting with .")
When a user runs statik -a or statik -a=true, they want to include dot files.
So, flagIgnoreDotFiles should be equal to ! flag.Bool("a"), which is very uncommon.
I don't mind renaming flagAllFiles. May be flagDoNotIgnoreDotFiles is less controversial ?
There was a problem hiding this comment.
Maybe considerDotFiles is easier to grok?
| // Each file is represented with a path, no directory | ||
| // entities are required to build the hierarchy. | ||
| if fi.IsDir() || strings.HasPrefix(fi.Name(), ".") { | ||
| if fi.IsDir() || (!*flagAllFiles && strings.HasPrefix(fi.Name(), ".")) { |
There was a problem hiding this comment.
I think (!*flagIgnoreDotFiles && strings.HasPrefix(fi.Name(), ".")) is more readable, it could also be in a next if (it is OK to keep it in this if too).
|
Can we use |
3 participants
No description provided.