fix Readdir(), Name() and New() to Walk properly#60
Closed
Songmu wants to merge 5 commits intorakyll:masterfrom
Closed
fix Readdir(), Name() and New() to Walk properly#60Songmu wants to merge 5 commits intorakyll:masterfrom
Songmu wants to merge 5 commits intorakyll:masterfrom
Conversation
Songmu
changed the title
rakyll
pushed a commit
that referenced
this pull request
Mar 20, 2019
Follow on #60. The Readdir() should support positive count in order to return the specified counts of files. For it, I defined statikFS.dirs and httpFile.dirIdx for managing the internal state and use it inside Readdir().
ekanna
pushed a commit
to ekanna/statik
that referenced
this pull request
Sep 12, 2019
Follow on rakyll#60. The Readdir() should support positive count in order to return the specified counts of files. For it, I defined statikFS.dirs and httpFile.dirIdx for managing the internal state and use it inside Readdir().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I correspond to the following problems in this pull request.
Readdirpick up only the entries just under the directory and do not follow grandchildfilesinNew()in order to care deep directorystat.Name()should return basename conventionally for recursive walkingThis fix is similar to #59, it is better than that as the modification is less.
close #59.