exiftool, Check whether exiftool is installed in the host system#7
Closed
dgrammlich wants to merge 1 commit intoramack:masterfrom
dgrammlich:2_check_if_exiftool_is_installed
Closed
exiftool, Check whether exiftool is installed in the host system#7dgrammlich wants to merge 1 commit intoramack:masterfrom dgrammlich:2_check_if_exiftool_is_installed
exiftool is installed in the host system#7dgrammlich wants to merge 1 commit intoramack:masterfrom
dgrammlich:2_check_if_exiftool_is_installed
Conversation
dgrammlich
commented
Oct 11, 2019
- refs Dependency on exiftool binary is not checked #2
Owner
|
Thanks a lot for your contribution! You PR will finally hide the fact that exiftool binary was not found on the server, in which case the use of the plugin is a bit strange from the start. By hiding the error I fear, that it might even trigger more questions, because it will not be visible - not even the administrator - to see that it will never do anything useful. So I think merging this makes sense as soon as we have a a message in the admin panel. |
Owner
|
ah BTW, did you take a look at #5? which solution do you prefer? But anyhow this also doesn't solve the problem that the server admin might install the plugin without it doing something useful ever without any warning... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.