Make jebl2 SequenceType and State easy to extend#6
Open
walterxie wants to merge 6 commits intorambaut:masterfrom
Open
Make jebl2 SequenceType and State easy to extend#6walterxie wants to merge 6 commits intorambaut:masterfrom
walterxie wants to merge 6 commits intorambaut:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rambaut
How are you? @alexeid and I are working on a project depending on
jebl2. I proposed few changes to make the code easy to extend. It will be much appreciated if you would have a look.Stateconstructor not "package private", so we can use our package name;protectedinNexusImporter;NexusImporter.getSequenceType(String)to allow handling new data types in the subclass;Binarydata type;SequenceType.Utils.getDataType(String)for Nexus parsing;NexusBlock, which can be used in new implementation or the subclass.