Remove old, problematic, and unnecessary renderError and clearError method defaults#491
Closed
cpsievert wants to merge 2 commits intoramnathv:masterfrom
Closed
Remove old, problematic, and unnecessary renderError and clearError method defaults#491cpsievert wants to merge 2 commits intoramnathv:masterfrom
renderError and clearError method defaults#491cpsievert wants to merge 2 commits intoramnathv:masterfrom
Conversation
…ror and clearError method defaults By removing these defaults, when the widget is in rendered in Shiny, it will simply fallback to Shiny's OutputBinding default methods, which does a better and simpler job of rendering and clearing errors. And, when rendering statically, the renderError/clearError methods aren't relevant
Collaborator
Author
|
After looking at this again, I now realize there is an intentional difference here and the generic output binding We could still move away from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490
By removing these defaults, when the widget is in rendered in Shiny, it will simply fallback to Shiny's OutputBinding default methods, which does a better and simpler job of rendering and clearing errors.
And, when rendering statically, the renderError/clearError methods aren't relevant