Skip to content

The graphgps data loader no longer overshadows all other dataloaders. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkminder wants to merge 3 commits into
base: main
Choose a base branch
from
Open

The graphgps data loader no longer overshadows all other dataloaders. #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7dadbe
The graphgps data loader no longer overshadows all other dataloaders.…
jkminder Mar 6, 2023
34dd9a7
gatedgcn layer now also supports graphs with no edge attributes
jkminder Mar 6, 2023
3a0be3e
Revert "gatedgcn layer now also supports graphs with no edge attributes"
jkminder Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions graphgps/loader/master_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,8 @@ def log_loaded_dataset(dataset, format, name):
@register_loader('custom_master_loader')
def load_dataset_master(format, name, dataset_dir):
"""
Master loader that controls loading of all datasets, overshadowing execution
of any default GraphGym dataset loader. Default GraphGym dataset loader are
instead called from this function, the format keywords `PyG` and `OGB` are
reserved for these default GraphGym loaders.
Master loader that controls loading of all GraphGPS datasets, overshadowing execution
of 'OGB' datasets.

Custom transforms and dataset splitting is applied to each loaded dataset.

Expand Down Expand Up @@ -143,11 +141,6 @@ def load_dataset_master(format, name, dataset_dir):

else:
raise ValueError(f"Unexpected PyG Dataset identifier: {format}")

# GraphGym default loader for Pytorch Geometric datasets
elif format == 'PyG':
dataset = load_pyg(name, dataset_dir)

elif format == 'OGB':
if name.startswith('ogbg'):
dataset = preformat_OGB_Graph(dataset_dir, name.replace('_', '-'))
Expand Down Expand Up @@ -178,7 +171,7 @@ def convert_to_int(ds, prop):
else:
raise ValueError(f"Unsupported OGB(-derived) dataset: {name}")
else:
raise ValueError(f"Unknown data format: {format}")
return None # Not a custom graphgps dataset. Fall back to other loaders

pre_transform_in_memory(dataset, partial(task_specific_preprocessing, cfg=cfg))

Expand Down