fix: prevent project task-form typing crash#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdandCLAUDE.mdwith required UI form behavior test rules to prevent recurrence.Validation
pnpm lintpnpm typecheckpnpm testAdditional validation run details:
pnpm installpnpm --filter @simple-agent-manager/shared buildpnpm --filter @simple-agent-manager/ui buildpnpm --filter @simple-agent-manager/acp-client buildpnpm --filter @simple-agent-manager/terminal buildpnpm --filter @simple-agent-manager/web typecheckpnpm --filter @simple-agent-manager/web lintpnpm --filter @simple-agent-manager/web testUI Compliance Checklist (Required for UI changes)
Exceptions (If any)
Agent Preflight (Required)
Classification
External References
N/A: no external API contract changes; code and existing project docs were sufficient.
Codebase Impact Analysis
apps/web/src/components/project/TaskForm.tsx(task form state update path)apps/web/tests/unit/components/project/task-form.test.tsx(new focused regression coverage)apps/web/tests/unit/pages/project.test.tsx(integration flow coverage)AGENTS.md,CLAUDE.md(testing guidance hardening)Documentation & Specs
AGENTS.mdCLAUDE.mdConstitution & Risk Check