Upgrade supported python versions #480
Open
+8
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @raphaelvallat,
this PR adds "official" support for newer Python versions up to 3.14 and drops support for EOL versions.
I removed one unit test for
**kwargsinlogistic_regression, becausemulti_classis not supported in newer scikit-learn versions. There is another test for kwargs anyway.Moreover I changed the max supported scikit-learn version to <1.8, because of changes to
MinCovDetin scikit-learn/scikit-learn#23162. The results ofskippedcorrelations do not match the Matlab implementation (at least based on the unit test). Currently the function returns incorrect results for all users that use scitkit-learn 1.8, so a quick update is needed. Alternatively we could add a check in theskippedfunction and raise an Exception if the sklearn-version is 1.8 or above.Unfortunately I do not have access to Matlab to compare the results and do not have the time to look into the
skippedcorrelation function in detail. It should be possible to fix it for newer sklearn versions and use different code paths.Based on the my problems I suggest to add unit tests against mayor and minor versions (including release candidates) of essential dependencies (pandas, scikit-learn, statsmodels, numpy, scipy). The test suite is very fast so and additional weekly run of wide test suite might help to catch similar problems early.