Set project version references to v1.3.0#8
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1268d3550
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err != nil { | ||
| fp.Close() | ||
| log.Fatal(err) | ||
| log.Printf("failed to open output file %q: %v", fw.FilePath, err) | ||
| return |
There was a problem hiding this comment.
If opening the output file fails (for example, the directory in FilePath does not exist), this branch logs and returns without starting any goroutine to consume the unbuffered channels returned by Consume(). The crawler then blocks indefinitely on its first send to the adapter NodeCh, so a recoverable configuration error turns into a hang rather than a clean failure/quit signal.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR updates release/version metadata to 1.3.0 and also modernizes the repository by introducing Go modules, CI workflows, and additional unit tests while adjusting a few error-handling behaviors in core/library paths.
Changes:
- Bump/normalize version references across
VERSION,README.md, andCHANGELOG.md. - Add Go module support (
go.mod,go.sum) and GitHub Actions workflows for CI and release publishing. - Add/expand unit tests and adjust some runtime behaviors (e.g., replacing
log.Fatalwithpanic/ early returns in library codepaths).
Reviewed changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| octopus/setup_test.go | Adds tests for rate-limit validation and TimeToQuit setup panic behavior. |
| octopus/setup.go | Changes invalid TimeToQuit handling from log.Fatal to panic. |
| octopus/pipes_test.go | Adds tests for link absolution, duplicate filtering, and timeout propagation. |
| octopus/pipe_spl_distributor.go | Cleans up distributor signature/logic and ensures quit propagation returns. |
| octopus/pipe_process_htmlparsing.go | Simplifies import and adds nil-guard before tokenizing/reading body. |
| octopus/pipe_ctrl_ratelimit.go | Simplifies import formatting. |
| octopus/pipe_augment_linkabsolution.go | Removes log.Fatal on nil inputs in favor of early return. |
| octopus/models.go | Comment formatting/indentation normalization for CrawlOptions docs. |
| octopus/modelfactory_test.go | Adds tests for default crawl options and channel-set factory helper. |
| octopus/htmlparse_test.go | Adds unit test for HTML anchor extraction behavior. |
| octopus/doc.go | Updates package docs formatting/headings for Go doc rendering. |
| go.mod | Introduces module definition and dependency requirements (with replaces). |
| go.sum | Adds dependency checksums. |
| adapter/doc.go | Fixes comment block formatting. |
| adapter/basicadapters_test.go | Adds unit test for FileWriterAdapter output behavior. |
| adapter/basicadapters.go | Adjusts adapter file open flags and error handling/logging. |
| VERSION | Sets repository version to 1.3.0. |
| README.md | Updates installation/version references and expands documentation content. |
| CHANGELOG.md | Normalizes/updates changelog with 1.3.0 section and modernization notes. |
| .travis.yml | Removes legacy Travis CI configuration. |
| .github/workflows/publish.yml | Adds release-published workflow to validate tags and trigger Go indexing/refresh. |
| .github/workflows/ci.yml | Adds PR/push CI workflow with tidy/format/vet/staticcheck/tests/race. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 participant
Motivation
1.3.0and eliminate iterative PR-driven version drift.Description
VERSIONto1.3.0, replaced installation and “current release” references inREADME.mdwithv1.3.0, and normalized the topCHANGELOG.mdsection to## [1.3.0] - 2026-02-10while removing the duplicate 1.3.0 section added by earlier iteration bumps.Testing
go test ./...,go vet ./..., andgit diff --check, and all automated checks completed successfully.Codex Task