Skip to content

Updates to use messages and broadcasts UUID fields#110

Merged
rowanseymour merged 1 commit intomainfrom
updates
Oct 8, 2025
Merged

Updates to use messages and broadcasts UUID fields#110
rowanseymour merged 1 commit intomainfrom
updates

Conversation

@norkans7
Copy link
Contributor

@norkans7 norkans7 commented Oct 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 8, 2025 16:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the messages and broadcasts API from using integer-based id fields to UUID-based uuid fields for primary identification. This change improves data consistency and aligns with modern API design practices that favor UUIDs over sequential integer IDs.

Key changes include:

  • Updated field definitions in data models to use uuid instead of id
  • Modified API method parameters to accept UUIDs instead of integer IDs
  • Updated test data and test cases to use UUID values

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test_files/v2/messages.json Updated test data to use UUID fields instead of id and broadcast integer fields
test_files/v2/broadcasts.json Updated test data to use UUID fields instead of integer id fields
temba_client/v2/types.py Modified Broadcast and Message model definitions to use uuid SimpleField instead of id IntegerField
temba_client/v2/tests.py Updated test assertions and method calls to use UUID values instead of integer IDs
temba_client/v2/init.py Updated get_broadcasts and get_messages method signatures to accept uuid parameters instead of id

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +209 to 210
uuid = SimpleField()
contact = ObjectField(item_class=ObjectRef)
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Message class definition appears incomplete. The uuid field is defined outside of a proper class definition - it should be properly indented within the Message class.

Copilot uses AI. Check for mistakes.
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.79%. Comparing base (3941f8a) to head (59334e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   99.79%   99.79%   -0.01%     
==========================================
  Files           9        9              
  Lines        1435     1433       -2     
==========================================
- Hits         1432     1430       -2     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rowanseymour rowanseymour merged commit 073b428 into main Oct 8, 2025
10 checks passed
@rowanseymour rowanseymour deleted the updates branch October 8, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants