Skip to content

Remove support for filtering runs by a single contact#111

Merged
rowanseymour merged 1 commit intomainfrom
get_runs_tweak
Oct 8, 2025
Merged

Remove support for filtering runs by a single contact#111
rowanseymour merged 1 commit intomainfrom
get_runs_tweak

Conversation

@rowanseymour
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 8, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for filtering flow runs by a single contact parameter from the temba_client v2 API. The change simplifies the get_runs method by removing the contact filtering capability.

  • Removed contact parameter from the get_runs method signature and documentation
  • Updated the internal parameter building to exclude the contact filter
  • Updated corresponding test cases to remove contact parameter usage

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
temba_client/v2/init.py Removed contact parameter from get_runs method signature, docstring, and parameter building
temba_client/v2/tests.py Updated test case to remove contact parameter from get_runs call and expected parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.79%. Comparing base (d46e053) to head (c296340).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files           9        9           
  Lines        1433     1433           
=======================================
  Hits         1430     1430           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rowanseymour rowanseymour merged commit 8077fee into main Oct 8, 2025
14 of 15 checks passed
@rowanseymour rowanseymour deleted the get_runs_tweak branch October 8, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants