Remove support for filtering runs by a single contact#111
Merged
rowanseymour merged 1 commit intomainfrom Oct 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for filtering flow runs by a single contact parameter from the temba_client v2 API. The change simplifies the get_runs method by removing the contact filtering capability.
- Removed
contactparameter from theget_runsmethod signature and documentation - Updated the internal parameter building to exclude the contact filter
- Updated corresponding test cases to remove contact parameter usage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| temba_client/v2/init.py | Removed contact parameter from get_runs method signature, docstring, and parameter building |
| temba_client/v2/tests.py | Updated test case to remove contact parameter from get_runs call and expected parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 9 9
Lines 1433 1433
=======================================
Hits 1430 1430
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.