Update get_flows and get_globals by adjusting filterable fields#112
Merged
rowanseymour merged 5 commits intomainfrom Oct 9, 2025
Merged
Update get_flows and get_globals by adjusting filterable fields#112rowanseymour merged 5 commits intomainfrom
rowanseymour merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the get_flows and get_globals methods to support additional filterable fields, improving the client's querying capabilities. The changes add new optional parameters to these methods and include corresponding test coverage.
- Added
typeandarchivedparameters toget_flowsmethod for better flow filtering - Added
keyparameter toget_globalsmethod to filter globals by field key - Enhanced test coverage for the new filtering parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| temba_client/v2/init.py | Updated method signatures and docstrings for get_flows and get_globals to support new filtering parameters |
| temba_client/v2/tests.py | Added comprehensive test cases for the new filtering parameters in both methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 9 9
Lines 1433 1451 +18
=======================================
+ Hits 1430 1448 +18
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rowanseymour
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.