Skip to content

Update get_flows and get_globals by adjusting filterable fields#112

Merged
rowanseymour merged 5 commits intomainfrom
more_updates
Oct 9, 2025
Merged

Update get_flows and get_globals by adjusting filterable fields#112
rowanseymour merged 5 commits intomainfrom
more_updates

Conversation

@norkans7
Copy link
Contributor

@norkans7 norkans7 commented Oct 9, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 9, 2025 10:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the get_flows and get_globals methods to support additional filterable fields, improving the client's querying capabilities. The changes add new optional parameters to these methods and include corresponding test coverage.

  • Added type and archived parameters to get_flows method for better flow filtering
  • Added key parameter to get_globals method to filter globals by field key
  • Enhanced test coverage for the new filtering parameters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
temba_client/v2/init.py Updated method signatures and docstrings for get_flows and get_globals to support new filtering parameters
temba_client/v2/tests.py Added comprehensive test cases for the new filtering parameters in both methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.79%. Comparing base (559e38b) to head (74a452c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files           9        9           
  Lines        1433     1451   +18     
=======================================
+ Hits         1430     1448   +18     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

norkans7 and others added 2 commits October 9, 2025 12:45
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@norkans7 norkans7 requested a review from rowanseymour October 9, 2025 12:16
@rowanseymour rowanseymour merged commit b31432e into main Oct 9, 2025
10 checks passed
@rowanseymour rowanseymour deleted the more_updates branch October 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants