Replace use of pickle.load in benchmark utility scripts#1041
Open
grlee77 wants to merge 2 commits intorapidsai:mainfrom
Open
Replace use of pickle.load in benchmark utility scripts#1041grlee77 wants to merge 2 commits intorapidsai:mainfrom
pickle.load in benchmark utility scripts#1041grlee77 wants to merge 2 commits intorapidsai:mainfrom
Conversation
This is tabular data, so just save/load via CSV is fine
grlee77
added
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code analysis tools flag
pickle.loadusage as a security risk. In practice we were only using it in some benchmarking utility scripts, not the library we distributed on PyPI/conda, so I don't think there was a real case.That said, there is not really a reason we need to use pickle for those scripts. We are already using
pandasfor them and can just save/load using CSV instead.