[REVIEW] Add Doxygen style comments to Join CUDA functions#561
[REVIEW] Add Doxygen style comments to Join CUDA functions#561harrism merged 9 commits intorapidsai:branch-0.6from BlazingDB:adding-documentations
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
add to whitelist |
harrism
changed the title
|
@jeanp413 Can you add a line to the CHANGELOG.md for this PR? (under 0.5.0 #improvements section). |
jeanp413
changed the title
|
@williamBlazing @jeanp413 can you get this PR synced up with branch-0.6 and get tests to pass? |
harrism
left a comment
harrism
left a comment
There was a problem hiding this comment.
Some small changes, including slight change to the format of block comments.
| gdf_context* ctxt); //context info | ||
| /* --------------------------------------------------------------------------*/ | ||
| /** | ||
| * @brief Performs SQL like WHERE (Filtering) |
There was a problem hiding this comment.
I think this is a good brief comment, but documentation should also include (after the brief) detailed explanation of the functions semantics, expected use, etc. Perhaps that is a task for a further PR. An issue should be filed if so.
There was a problem hiding this comment.
I will create an issue in that case. We did not create this function, nor do we use it, so we would not be the best for providing a detailed explanation of the functions semantics, expected use, etc
4 participants
Doxygen style comments moved from old libgdf repo rapidsai/libgdf#156