rapids-get-pr-artifact: stricter, fewer API calls, less expensive#249
Open
rapids-get-pr-artifact: stricter, fewer API calls, less expensive#249
Conversation
jameslamb
added
improvement
3 tasks
jameslamb
changed the title
jameslamb
commented
Mar 10, 2026
| --repo "${repo}" \ | ||
| --branch "pull-request/${pr}" \ | ||
| --commit "${commit}" \ | ||
| --workflow "${workflow_that_produced_artifacts}" \ |
Member
Author
There was a problem hiding this comment.
Adding --workflow limits the search space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using
rapids-get-pr-artifacta lot recently, for rapidsai/build-planning#257Today, one of my PRs for that briefly caused
cudfto briefly exceed its GitHub API limits: rapidsai/cudf#21671 (comment)This proposes some fixes to
rapids-get-pr-artifactin the future:gh run download, which causes it to page over all CI runs GitHub's history retains)pr.yamlworkflowRAPIDS_BUILD_WORKFLOW_NAME)These should make
rapids-get-pr-artifactfaster and, more importantly, use many fewer GitHub API calls.Notes for Reviewers
Haven't I seen this before?
Yep! Similar changes were made in
rapids-github-run-id:rapids-get-pr-artifactdoesn't userapids-github-run-idbecause its behavior of "use environment variableGITHUB_RUN_IDif it's available" is undesirable when you're trying to workflow runs in a repo other than the onerapids-get-pr-artifactis currently running in.How I tested this
Tested on rapidsai/cudf#21671, with rapidsai/cudf@c058c43