Add C++ benchmarks (part 1/n)#659
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
098be83 to
858b2f8
Compare
KyleFromNVIDIA
left a comment
There was a problem hiding this comment.
Just a few small CMake issues that should be fixed.
|
Thanks @kingcrimsontianyu this is a great start! I think the "Time" column makes sense to me, showing an optimum of 8 threads in both the weak and strong scaling cases. The "CPU" column doesn't make much sense to me though. |
mhaseeb123
left a comment
There was a problem hiding this comment.
Would appreciate some comments in threadpool_benchmark.cpp
|
@GregoryKimball |
|
To avoid confusion, explanation of the metrics is added to the result in another ongoing PR (#664). |
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
2a3f76f to
3f3a620
Compare
|
/merge |

Partially addresses #606
This PR kick-starts the process of adding benchmarks to KvikIO. The following tasks are done:
To build and run the benchmark programs in the dev container:
Sample output: