-
Notifications
You must be signed in to change notification settings - Fork 2
[CI] Enable devcontainer jobs #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # syntax=docker/dockerfile:1.5 | ||
|
|
||
| ARG BASE | ||
| ARG PYTHON_PACKAGE_MANAGER=conda | ||
|
|
||
| FROM ${BASE} as pip-base | ||
|
|
||
| ENV DEFAULT_VIRTUAL_ENV=rapids | ||
| ENV RAPIDS_LIBUCX_PREFER_SYSTEM_LIBRARY=true | ||
|
|
||
| RUN apt update -y \ | ||
| && DEBIAN_FRONTEND=noninteractive apt install -y \ | ||
| libblas-dev liblapack-dev \ | ||
| && rm -rf /tmp/* /var/tmp/* /var/cache/apt/* /var/lib/apt/lists/*; | ||
|
|
||
| FROM ${BASE} as conda-base | ||
|
|
||
| ENV DEFAULT_CONDA_ENV=rapids | ||
|
|
||
| FROM ${PYTHON_PACKAGE_MANAGER}-base | ||
|
|
||
| ARG TARGETARCH | ||
|
|
||
| ARG CUDA | ||
| ENV CUDAARCHS="RAPIDS" | ||
| ENV CUDA_VERSION="${CUDA_VERSION:-${CUDA}}" | ||
|
|
||
| ARG PYTHON_PACKAGE_MANAGER | ||
| ENV PYTHON_PACKAGE_MANAGER="${PYTHON_PACKAGE_MANAGER}" | ||
|
|
||
| ENV PYTHONSAFEPATH="1" | ||
| ENV PYTHONUNBUFFERED="1" | ||
| ENV PYTHONDONTWRITEBYTECODE="1" | ||
|
|
||
| ENV HISTFILE="/home/coder/.cache/._bash_history" | ||
|
|
||
| ### | ||
| # sccache configuration | ||
| ### | ||
| ENV AWS_ROLE_ARN="arn:aws:iam::279114543810:role/nv-gha-token-sccache-devs" | ||
| ENV SCCACHE_REGION="us-east-2" | ||
| ENV SCCACHE_BUCKET="rapids-sccache-devs" | ||
| ENV SCCACHE_S3_USE_PREPROCESSOR_CACHE_MODE=true | ||
| ENV SCCACHE_IDLE_TIMEOUT=0 | ||
|
|
||
| ### | ||
| # sccache-dist configuration | ||
| ### | ||
| # Enable sccache-dist by default | ||
| ENV DEVCONTAINER_UTILS_ENABLE_SCCACHE_DIST=1 | ||
| # Compile locally if max retries exceeded | ||
| ENV SCCACHE_DIST_FALLBACK_TO_LOCAL_COMPILE=true | ||
| # Retry transient errors 4 times (for a total of 5 attempts) | ||
| ENV SCCACHE_DIST_MAX_RETRIES=4 | ||
| # 1hr 59min (to accommodate debug builds) | ||
| ENV SCCACHE_DIST_REQUEST_TIMEOUT=7140 | ||
| ENV SCCACHE_DIST_URL="https://${TARGETARCH}.linux.sccache.rapids.nvidia.com" | ||
|
|
||
| # Build as much in parallel as possible | ||
| ENV INFER_NUM_DEVICE_ARCHITECTURES=1 | ||
| ENV MAX_DEVICE_OBJ_TO_COMPILE_IN_PARALLEL=20 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # nvForest Development Containers | ||
|
|
||
| This directory contains [devcontainer configurations](https://containers.dev/implementors/json_reference/) for using VSCode to [develop in a container](https://code.visualstudio.com/docs/devcontainers/containers) via the `Remote Containers` [extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) or [GitHub Codespaces](https://github.com/codespaces). | ||
|
|
||
| This container is a turnkey development environment for building and testing the nvForest C++ and Python libraries. | ||
|
|
||
| ## Table of Contents | ||
|
|
||
| * [Prerequisites](#prerequisites) | ||
| * [Host bind mounts](#host-bind-mounts) | ||
| * [Launch a Dev Container](#launch-a-dev-container) | ||
|
|
||
| ## Prerequisites | ||
|
|
||
| * [VSCode](https://code.visualstudio.com/download) | ||
| * [VSCode Remote Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) | ||
|
|
||
| ## Host bind mounts | ||
|
|
||
| By default, the following directories are bind-mounted into the devcontainer: | ||
|
|
||
| * `${repo}:/home/coder/nvforest` | ||
| * `${repo}/../.aws:/home/coder/.aws` | ||
| * `${repo}/../.local:/home/coder/.local` | ||
| * `${repo}/../.cache:/home/coder/.cache` | ||
| * `${repo}/../.conda:/home/coder/.conda` | ||
| * `${repo}/../.config:/home/coder/.config` | ||
|
|
||
| This ensures caches, configurations, dependencies, and your commits are persisted on the host across container runs. | ||
|
|
||
| ## Launch a Dev Container | ||
|
|
||
| To launch a devcontainer from VSCode, open the nvForest repo and select the "Reopen in Container" button in the bottom right:<br/><img src="https://user-images.githubusercontent.com/178183/221771999-97ab29d5-e718-4e5f-b32f-2cdd51bba25c.png"/> | ||
|
|
||
| Alternatively, open the VSCode command palette (typically `cmd/ctrl + shift + P`) and run the "Rebuild and Reopen in Container" command. | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,44 @@ | ||||||||||
| { | ||||||||||
| "build": { | ||||||||||
| "context": "${localWorkspaceFolder}/.devcontainer", | ||||||||||
| "dockerfile": "${localWorkspaceFolder}/.devcontainer/Dockerfile", | ||||||||||
| "args": { | ||||||||||
| "CUDA": "12.9", | ||||||||||
| "PYTHON_PACKAGE_MANAGER": "conda", | ||||||||||
| "BASE": "rapidsai/devcontainers:26.04-cpp-mambaforge" | ||||||||||
| } | ||||||||||
| }, | ||||||||||
| "runArgs": [ | ||||||||||
| "--rm", | ||||||||||
| "--name", | ||||||||||
| "${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.04-cuda12.9-conda", | ||||||||||
| "--ulimit", | ||||||||||
| "nofile=500000" | ||||||||||
| ], | ||||||||||
| "hostRequirements": {"gpu": "optional"}, | ||||||||||
| "features": { | ||||||||||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:26.4": {} | ||||||||||
| }, | ||||||||||
| "overrideFeatureInstallOrder": [ | ||||||||||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils" | ||||||||||
| ], | ||||||||||
| "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config,conda/pkgs,conda/${localWorkspaceFolderBasename}-cuda12.9-envs}"], | ||||||||||
| "postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; . rapids-post-attach-command; fi"], | ||||||||||
| "workspaceFolder": "/home/coder", | ||||||||||
| "workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/nvforest,type=bind,consistency=consistent", | ||||||||||
|
Comment on lines
+27
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, let's look at the full devcontainer.json file
cat -n .devcontainer/cuda12.9-conda/devcontainer.jsonRepository: rapidsai/nvforest Length of output: 2320 🏁 Script executed: # Check if there are other devcontainer configurations for comparison
find .devcontainer -name "devcontainer.json" -type fRepository: rapidsai/nvforest Length of output: 244 🏁 Script executed: # Let's also check the directory structure to understand the context
ls -la .devcontainer/Repository: rapidsai/nvforest Length of output: 550 🏁 Script executed: # Check the other devcontainer configurations for the same issue
for file in .devcontainer/cuda12.9-pip/devcontainer.json .devcontainer/cuda13.1-conda/devcontainer.json .devcontainer/cuda13.1-pip/devcontainer.json; do
echo "=== $file ==="
grep -A 1 "workspaceFolder\|workspaceMount" "$file"
doneRepository: rapidsai/nvforest Length of output: 716 Point The repo is mounted at Patch- "workspaceFolder": "/home/coder",
+ "workspaceFolder": "/home/coder/nvforest",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
| "mounts": [ | ||||||||||
| "source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.conda/pkgs,target=/home/coder/.conda/pkgs,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.conda/${localWorkspaceFolderBasename}-cuda12.9-envs,target=/home/coder/.conda/envs,type=bind,consistency=consistent" | ||||||||||
| ], | ||||||||||
| "customizations": { | ||||||||||
| "vscode": { | ||||||||||
| "extensions": [ | ||||||||||
| "ms-python.flake8", | ||||||||||
| "nvidia.nsight-vscode-edition" | ||||||||||
| ] | ||||||||||
| } | ||||||||||
| } | ||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,51 @@ | ||||||||||
| { | ||||||||||
| "build": { | ||||||||||
| "context": "${localWorkspaceFolder}/.devcontainer", | ||||||||||
| "dockerfile": "${localWorkspaceFolder}/.devcontainer/Dockerfile", | ||||||||||
| "args": { | ||||||||||
| "CUDA": "12.9", | ||||||||||
| "PYTHON_PACKAGE_MANAGER": "pip", | ||||||||||
| "BASE": "rapidsai/devcontainers:26.04-cpp-cuda12.9-ucx1.19.0-openmpi5.0.7" | ||||||||||
| } | ||||||||||
| }, | ||||||||||
| "runArgs": [ | ||||||||||
| "--rm", | ||||||||||
| "--name", | ||||||||||
| "${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.04-cuda12.9-pip", | ||||||||||
| "--ulimit", | ||||||||||
| "nofile=500000" | ||||||||||
| ], | ||||||||||
| "hostRequirements": {"gpu": "optional"}, | ||||||||||
| "features": { | ||||||||||
| "ghcr.io/rapidsai/devcontainers/features/cuda:26.4": { | ||||||||||
| "version": "12.9", | ||||||||||
| "installcuBLAS": true, | ||||||||||
| "installcuSOLVER": true, | ||||||||||
| "installcuRAND": true, | ||||||||||
| "installcuSPARSE": true | ||||||||||
| }, | ||||||||||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:26.4": {} | ||||||||||
| }, | ||||||||||
| "overrideFeatureInstallOrder": [ | ||||||||||
| "ghcr.io/rapidsai/devcontainers/features/cuda", | ||||||||||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils" | ||||||||||
| ], | ||||||||||
| "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config/pip,local/share/${localWorkspaceFolderBasename}-cuda12.9-venvs}"], | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
workspace='/tmp/My Repo/nvforest'
bash -lc "set -- ${workspace}/../.{aws,cache,config/pip,local/share/nvforest-cuda12.9-venvs}; printf '<%s>\n' \"\$@\""Repository: rapidsai/nvforest Length of output: 323 Quote The unquoted path on Line 33 is split by the shell at whitespace. A checkout like 🐛 Proposed fix- "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config/pip,local/share/${localWorkspaceFolderBasename}-cuda12.9-venvs}"],
+ "initializeCommand": ["/bin/bash", "-c", "workspace_parent=$(dirname \"${localWorkspaceFolder}\") && mkdir -m 0755 -p \"$workspace_parent/.aws\" \"$workspace_parent/.cache\" \"$workspace_parent/.config/pip\" \"$workspace_parent/.local/share/${localWorkspaceFolderBasename}-cuda12.9-venvs\""],📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
| "postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; . rapids-post-attach-command; fi"], | ||||||||||
| "workspaceFolder": "/home/coder", | ||||||||||
| "workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/nvforest,type=bind,consistency=consistent", | ||||||||||
|
Comment on lines
+35
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
python - <<'PY'
import json
from pathlib import Path
path = Path(".devcontainer/cuda12.9-pip/devcontainer.json")
data = json.loads(path.read_text())
target = next(
part.split("=", 1)[1]
for part in data["workspaceMount"].split(",")
if part.startswith("target=")
)
print("workspaceFolder:", data["workspaceFolder"])
print("workspaceMount target:", target)
print("matches:", data["workspaceFolder"] == target)
PYRepository: rapidsai/nvforest Length of output: 148 🏁 Script executed: cat -n .devcontainer/cuda12.9-pip/devcontainer.jsonRepository: rapidsai/nvforest Length of output: 2545 Point Line 35 opens Proposed fix- "workspaceFolder": "/home/coder",
+ "workspaceFolder": "/home/coder/nvforest",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
| "mounts": [ | ||||||||||
| "source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent", | ||||||||||
| "source=${localWorkspaceFolder}/../.local/share/${localWorkspaceFolderBasename}-cuda12.9-venvs,target=/home/coder/.local/share/venvs,type=bind,consistency=consistent" | ||||||||||
| ], | ||||||||||
| "customizations": { | ||||||||||
| "vscode": { | ||||||||||
| "extensions": [ | ||||||||||
| "ms-python.flake8", | ||||||||||
| "nvidia.nsight-vscode-edition" | ||||||||||
| ] | ||||||||||
| } | ||||||||||
| } | ||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "build": { | ||
| "context": "${localWorkspaceFolder}/.devcontainer", | ||
| "dockerfile": "${localWorkspaceFolder}/.devcontainer/Dockerfile", | ||
| "args": { | ||
| "CUDA": "13.1", | ||
| "PYTHON_PACKAGE_MANAGER": "conda", | ||
| "BASE": "rapidsai/devcontainers:26.04-cpp-mambaforge" | ||
| } | ||
| }, | ||
| "runArgs": [ | ||
| "--rm", | ||
| "--name", | ||
| "${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.04-cuda13.1-conda", | ||
| "--ulimit", | ||
| "nofile=500000" | ||
| ], | ||
| "hostRequirements": {"gpu": "optional"}, | ||
| "features": { | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:26.4": {} | ||
| }, | ||
| "overrideFeatureInstallOrder": [ | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils" | ||
| ], | ||
| "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config,conda/pkgs,conda/${localWorkspaceFolderBasename}-cuda13.1-envs}"], | ||
| "postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; . rapids-post-attach-command; fi"], | ||
| "workspaceFolder": "/home/coder", | ||
| "workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/nvforest,type=bind,consistency=consistent", | ||
| "mounts": [ | ||
| "source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.conda/pkgs,target=/home/coder/.conda/pkgs,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.conda/${localWorkspaceFolderBasename}-cuda13.1-envs,target=/home/coder/.conda/envs,type=bind,consistency=consistent" | ||
| ], | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-python.flake8", | ||
| "nvidia.nsight-vscode-edition" | ||
| ] | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| { | ||
| "build": { | ||
| "context": "${localWorkspaceFolder}/.devcontainer", | ||
| "dockerfile": "${localWorkspaceFolder}/.devcontainer/Dockerfile", | ||
| "args": { | ||
| "CUDA": "13.1", | ||
| "PYTHON_PACKAGE_MANAGER": "pip", | ||
| "BASE": "rapidsai/devcontainers:26.04-cpp-cuda13.1-ucx1.19.0-openmpi5.0.7" | ||
| } | ||
| }, | ||
| "runArgs": [ | ||
| "--rm", | ||
| "--name", | ||
| "${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.04-cuda13.1-pip", | ||
| "--ulimit", | ||
| "nofile=500000" | ||
| ], | ||
| "hostRequirements": {"gpu": "optional"}, | ||
| "features": { | ||
| "ghcr.io/rapidsai/devcontainers/features/cuda:26.4": { | ||
| "version": "13.1", | ||
| "installcuBLAS": true, | ||
| "installcuSOLVER": true, | ||
| "installcuRAND": true, | ||
| "installcuSPARSE": true | ||
| }, | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:26.4": {} | ||
| }, | ||
| "overrideFeatureInstallOrder": [ | ||
| "ghcr.io/rapidsai/devcontainers/features/cuda", | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils" | ||
| ], | ||
| "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config/pip,local/share/${localWorkspaceFolderBasename}-cuda13.1-venvs}"], | ||
| "postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; . rapids-post-attach-command; fi"], | ||
| "workspaceFolder": "/home/coder", | ||
| "workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/nvforest,type=bind,consistency=consistent", | ||
| "mounts": [ | ||
| "source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.local/share/${localWorkspaceFolderBasename}-cuda13.1-venvs,target=/home/coder/.local/share/venvs,type=bind,consistency=consistent" | ||
| ], | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-python.flake8", | ||
| "nvidia.nsight-vscode-edition" | ||
| ] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add alt text to the image for accessibility.
The image tag is missing alternative text, which is required for accessibility compliance. Static analysis flagged this as MD045 (no-alt-text).
📝 Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 33-33: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents