rapids-cmake dependency tracking now understands COMPONENTS#234
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-22.10from Sep 6, 2022
Merged
Conversation
robertmaynard
added
feature request
vyasr
reviewed
Aug 5, 2022
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
There's a few things that need to be addressed here, but I've left comments rather than requesting changes since I'm out next week.
rapids-cmake/export/template/build_package_components_versioned.cmake.in
Show resolved
Hide resolved
robertmaynard
force-pushed
the
rapids_understand_find_components
branch
from
d12530e to
5cada07
Compare
vyasr
approved these changes
Sep 1, 2022
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Sorry not sure if you were waiting on my approval to merge this. It LGTM.
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228