Add pre-commit hook to check dask version consistency#148
Add pre-commit hook to check dask version consistency#148rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
Conversation
|
This will fail checks until #147 is forward-merged. |
|
Thanks Bradley! 🙏 So this should fail already as they are inconsistent currently rapids-dask-dependency/dependencies.yaml Lines 35 to 40 in 8aa3e89 rapids-dask-dependency/pyproject.toml Lines 14 to 17 in 8aa3e89 |
|
Output: https://github.com/rapidsai/rapids-dask-dependency/actions/runs/21461284750/job/61814178623?pr=148 |
|
This is a great idea, thanks @bdice ! I now have a new, more challenging ask based on this idea, can we proliferate this idea and do the same with our |
|
/merge |
Great question. tl;dr We haven't implemented this yet. It is tracked in rapidsai/dependency-file-generator#7. This was blocked for a long time due to the |
Summary
dependencies.yaml,pyproject.toml, andconda/recipes/rapids-dask-dependency/recipe.yamlThis addresses the issue seen in #142 and #147 where the conda recipe was not updated when the dask version was changed in
dependencies.yaml.The hook: