Add context manager to enable/disable patching#48
Open
rjzamora wants to merge 1 commit intorapidsai:branch-24.06from
Open
Add context manager to enable/disable patching#48rjzamora wants to merge 1 commit intorapidsai:branch-24.06from
rjzamora wants to merge 1 commit intorapidsai:branch-24.06from
Conversation
rjzamora
added
improvement
pentschev
reviewed
May 22, 2024
vyasr
requested changes
May 23, 2024
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Instead of rewriting the environment each time in the CM, can we load it once at the module level and store it in a module-scope var that is overwritten temporarily in the CM? Modifying the environment each time feels pretty heavyweight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by @vyasr 's suggestion in #46
Adds a simple context/utility to toggle patching behavior. This should make it easier to quickly test if patching is causing a hypothetical bug in the future.