Skip to content

Fix compiler warnings for deprecated APIs#903

Open
Matt711 wants to merge 2 commits intorapidsai:mainfrom
Matt711:imp/tpch/compiler-warning
Open

Fix compiler warnings for deprecated APIs#903
Matt711 wants to merge 2 commits intorapidsai:mainfrom
Matt711:imp/tpch/compiler-warning

Conversation

@Matt711
Copy link
Contributor

@Matt711 Matt711 commented Mar 5, 2026

Fixes compiler warnings:

Details
 In file included from /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q09.cpp:19:                                          
  /home/coder/cudf/cpp/include/cudf/round.hpp:66:40: note: declared here                                                         
     66 | [[deprecated]] std::unique_ptr<column> round(                                                                          
        |                                        ^~~~~                                                                           
  [189/222] Building CXX object benchmarks/streaming/ndsh/CMakeFiles/q03.dir/q03.cpp.o                                           
  /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q03.cpp: In function 'rapidsmpf::streaming::Actor                          
  {anonymous}::select_columns_for_groupby(std::shared_ptr<rapidsmpf::streaming::Context>,                                        
  std::shared_ptr<rapidsmpf::streaming::Channel>, std::shared_ptr<rapidsmpf::streaming::Channel>)':                              
  /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q03.cpp:263:28: warning: 'std::unique_ptr<cudf::column>                    
  cudf::transform(const std::vector<column_view>&, const std::string&, data_type, bool, std::optional<void*>, null_aware,        
  output_nullability, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated: Use transform_extended instead      
  [-Wdeprecated-declarations]                                                                                                    
    263 |             cudf::transform(                                                                                           
        |             ~~~~~~~~~~~~~~~^                                                                                           
    264 |                 {extendedprice, discount},                                                                             
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                             
    265 |                 udf,                                                                                                   
        |                 ~~~~                                                                                                   
    266 |                 cudf::data_type(cudf::type_id::FLOAT64),                                                               
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                               
    267 |                 false,                                                                                                 
        |                 ~~~~~~                                                                                                 
    268 |                 std::nullopt,                                                                                          
        |                 ~~~~~~~~~~~~~                                                                                          
    269 |                 cudf::null_aware::NO,                                                                                  
        |                 ~~~~~~~~~~~~~~~~~~~~~                                                                                  
    270 |                 cudf::output_nullability::PRESERVE,                                                                    
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                    
    271 |                 chunk_stream,                                                                                          
        |                 ~~~~~~~~~~~~~                                                                                          
    272 |                 ctx->br()->device_mr()                                                                                 
        |                 ~~~~~~~~~~~~~~~~~~~~~~                                                                                 
    273 |             )                                                                                                          
        |             ~                                                                                                          
  In file included from /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q03.cpp:28:                                          
  /home/coder/cudf/cpp/include/cudf/transform.hpp:59:74: note: declared here                                                     
     59 | [[deprecated("Use transform_extended instead")]] std::unique_ptr<column> transform(                                    
        |                                                                          ^~~~~~~~~                                     
  [191/222] Building CXX object benchmarks/streaming/ndsh/CMakeFiles/q01.dir/q01.cpp.o                                           
  /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q01.cpp: In function 'rapidsmpf::streaming::Actor                          
  {anonymous}::select_columns_for_groupby(std::shared_ptr<rapidsmpf::streaming::Context>,                                        
  std::shared_ptr<rapidsmpf::streaming::Channel>, std::shared_ptr<rapidsmpf::streaming::Channel>)':                              
  /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q01.cpp:226:28: warning: 'std::unique_ptr<cudf::column>                    
  cudf::transform(const std::vector<column_view>&, const std::string&, data_type, bool, std::optional<void*>, null_aware,        
  output_nullability, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated: Use transform_extended instead      
  [-Wdeprecated-declarations]                                                                                                    
    226 |             cudf::transform(                                                                                           
        |             ~~~~~~~~~~~~~~~^                                                                                           
    227 |                 {extendedprice, discount},                                                                             
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                             
    228 |                 udf_disc_price,                                                                                        
        |                 ~~~~~~~~~~~~~~~                                                                                        
    229 |                 cudf::data_type(cudf::type_id::FLOAT64),                                                               
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                               
    230 |                 false,                                                                                                 
        |                 ~~~~~~                                                                                                 
    231 |                 std::nullopt,                                                                                          
        |                 ~~~~~~~~~~~~~                                                                                          
    232 |                 cudf::null_aware::NO,                                                                                  
        |                 ~~~~~~~~~~~~~~~~~~~~~                                                                                  
    233 |                 cudf::output_nullability::PRESERVE,                                                                    
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                    
    234 |                 chunk_stream,                                                                                          
        |                 ~~~~~~~~~~~~~                                                                                          
    235 |                 ctx->br()->device_mr()                                                                                 
        |                 ~~~~~~~~~~~~~~~~~~~~~~                                                                                 
    236 |             )                                                                                                          
        |             ~                                                                                                          
  In file included from /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q01.cpp:21:                                          
  /home/coder/cudf/cpp/include/cudf/transform.hpp:59:74: note: declared here                                                     
     59 | [[deprecated("Use transform_extended instead")]] std::unique_ptr<column> transform(                                    
        |                                                                          ^~~~~~~~~                                     
  /home/coder/rapidsmpf/cpp/benchmarks/streaming/ndsh/q01.cpp:240:28: warning: 'std::unique_ptr<cudf::column>                    
  cudf::transform(const std::vector<column_view>&, const std::string&, data_type, bool, std::optional<void*>, null_aware,        
  output_nullability, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated: Use transform_extended instead      
  [-Wdeprecated-declarations]                                                                                                    
    240 |             cudf::transform(                                                                                           
        |             ~~~~~~~~~~~~~~~^                                                                                           
    241 |                 {result.back()->view(), tax},                                                                          
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                          
    242 |                 udf_charge,                                                                                            
        |                 ~~~~~~~~~~~                                                                                            
    243 |                 cudf::data_type(cudf::type_id::FLOAT64),                                                               
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                               
    244 |                 false,                                                                                                 
        |                 ~~~~~~                                                                                                 
    245 |                 std::nullopt,                                                                                          
        |                 ~~~~~~~~~~~~~                                                                                          
    246 |                 cudf::null_aware::NO,                                                                                  
        |                 ~~~~~~~~~~~~~~~~~~~~~                                                                                  
    247 |                 cudf::output_nullability::PRESERVE,                                                                    
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                    
    248 |                 chunk_stream,                                                                                          
        |                 ~~~~~~~~~~~~~                                                                                          
    249 |                 ctx->br()->device_mr()                                                                                 
        |                 ~~~~~~~~~~~~~~~~~~~~~~                                                                                 
    250 |             )                                                                                                          
        |             ~                                                                                                          
  /home/coder/cudf/cpp/include/cudf/transform.hpp:59:74: note: declared here                                                     
     59 | [[deprecated("Use transform_extended instead")]] std::unique_ptr<column> transform(                                    
        |                           

@Matt711 Matt711 requested a review from a team as a code owner March 5, 2026 14:26
@Matt711 Matt711 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 5, 2026
@Matt711 Matt711 requested a review from madsbk March 10, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants