Skip to content

Add username-based Docker image tagging to prevent multi-user conflicts#212

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/add-username-to-docker-tag
Draft

Add username-based Docker image tagging to prevent multi-user conflicts#212
Copilot wants to merge 4 commits intomainfrom
copilot/add-username-to-docker-tag

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

When multiple users build Presto images on shared systems, they overwrite each other's images due to hardcoded :latest tags on all coordinator, worker, and dependency images.

Changes

Default tag resolution:

  • Images now tagged with ${USER:-latest} by default
  • Applied to: presto-coordinator, presto-native-worker-{cpu,gpu}, presto-java-worker, and presto/prestissimo-dependency:centos9

CLI interface:

  • Added --tag option to start_*_presto.sh, build_centos_deps_image.sh, and fetch_centos_deps_image.sh
  • Existing --image-name in build script takes precedence over --tag for full control

Build integration:

  • native_build.dockerfile: Accepts IMAGE_TAG build arg for base image selection
  • docker-compose.common.yml: Passes IMAGE_TAG to native worker builds
  • Dependency image reference updated: presto/prestissimo-dependency:centos9-${IMAGE_TAG}

Example

# Default: uses $USER
./build_centos_deps_image.sh  # → presto/prestissimo-dependency:centos9-alice
./start_native_gpu_presto.sh  # → presto-native-worker-gpu:alice

# Override
./start_native_gpu_presto.sh --tag experiment-1  # → presto-native-worker-gpu:experiment-1
Original prompt

This section details on the original issue you should resolve

<issue_title>Add Username to TAG for docker images</issue_title>
<issue_description>When many people are working on same systems with Presto, and they try to run and build Presto images, it ends up replacing images

presto-native-worker-cpu:latest
presto-native-worker-gpu:latest
presto-coordinator:latest

It's because they all share same name and tag.
So, make sure to add username to the TAG so that other users don't replace latest images.

</issue_description>

<agent_instructions>make sure in include username as default tag to all docker images built.
Expose --tag option as CLI argument too, with default value as username.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@karthikeyann Reopening issue, because This issue is present in https://github.com/rapidsai/velox-testing/blob/main/presto/scripts/build_centos_deps_image.sh and their usage of presto/prestissimo-dependency:centos9 in other scripts as well. Also, please check if this dependency is use for building all presto-native-worker-cpu:latest presto-native-worker-gpu:latest presto-coordinator:latest @GregoryKimball Thank you @karthikeyann for reopening this. I would like to streamline the process for running quick Presto benchmarks based on GPU images.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits February 5, 2026 02:22
Co-authored-by: karthikeyann <6488848+karthikeyann@users.noreply.github.com>
Co-authored-by: karthikeyann <6488848+karthikeyann@users.noreply.github.com>
Co-authored-by: karthikeyann <6488848+karthikeyann@users.noreply.github.com>
Copilot AI changed the title [WIP] Add username to TAG for docker images Add username-based Docker image tagging to prevent multi-user conflicts Feb 5, 2026
Copilot AI requested a review from karthikeyann February 5, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Username to TAG for docker images

2 participants